| Message ID | 20201121114455.22422-3-kurt@linutronix.de |
|---|---|
| State | New |
| Headers | show |
| Series | [net-next,1/2] net: dsa: tag_hellcreek: Cleanup includes | expand |
On Sat, Nov 21, 2020 at 12:44:55PM +0100, Kurt Kanzenbach wrote: > When DSA is not loaded when the driver is probed an error message is > printed. But, that's not really an error, just a defer. Use dev_err_probe() > instead. > > Signed-off-by: Kurt Kanzenbach <kurt@linutronix.de> > --- Reviewed-by: Vladimir Oltean <olteanv@gmail.com>
diff --git a/drivers/net/dsa/hirschmann/hellcreek.c b/drivers/net/dsa/hirschmann/hellcreek.c index d42f40c76ba5..6420b76ea37c 100644 --- a/drivers/net/dsa/hirschmann/hellcreek.c +++ b/drivers/net/dsa/hirschmann/hellcreek.c @@ -1266,7 +1266,7 @@ static int hellcreek_probe(struct platform_device *pdev) ret = dsa_register_switch(hellcreek->ds); if (ret) { - dev_err(dev, "Unable to register switch\n"); + dev_err_probe(dev, ret, "Unable to register switch\n"); return ret; }
When DSA is not loaded when the driver is probed an error message is printed. But, that's not really an error, just a defer. Use dev_err_probe() instead. Signed-off-by: Kurt Kanzenbach <kurt@linutronix.de> --- drivers/net/dsa/hirschmann/hellcreek.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)