diff mbox series

[net] dpaa2-eth: Fix compile error due to missing devlink support

Message ID 20201123163553.1666476-1-ciorneiioana@gmail.com
State New
Headers show
Series [net] dpaa2-eth: Fix compile error due to missing devlink support | expand

Commit Message

Ioana Ciornei Nov. 23, 2020, 4:35 p.m. UTC 
From: Ezequiel Garcia <ezequiel@collabora.com>

The dpaa2 driver depends on devlink, so it should select
NET_DEVLINK in order to fix compile errors, such as:

drivers/net/ethernet/freescale/dpaa2/dpaa2-eth.o: in function `dpaa2_eth_rx_err':
dpaa2-eth.c:(.text+0x3cec): undefined reference to `devlink_trap_report'
drivers/net/ethernet/freescale/dpaa2/dpaa2-eth-devlink.o: in function `dpaa2_eth_dl_info_get':
dpaa2-eth-devlink.c:(.text+0x160): undefined reference to `devlink_info_driver_name_put'

Fixes: ceeb03ad8e22 ("dpaa2-eth: add basic devlink support")
Signed-off-by: Ezequiel Garcia <ezequiel@collabora.com>
Signed-off-by: Ioana Ciornei <ioana.ciornei@nxp.com>
---
 drivers/net/ethernet/freescale/dpaa2/Kconfig | 1 +
 1 file changed, 1 insertion(+)

Comments

patchwork-bot+netdevbpf@kernel.org Nov. 24, 2020, 11 p.m. UTC | #1 
Hello:

This patch was applied to netdev/net.git (refs/heads/master):

On Mon, 23 Nov 2020 18:35:53 +0200 you wrote:
> From: Ezequiel Garcia <ezequiel@collabora.com>

> 

> The dpaa2 driver depends on devlink, so it should select

> NET_DEVLINK in order to fix compile errors, such as:

> 

> drivers/net/ethernet/freescale/dpaa2/dpaa2-eth.o: in function `dpaa2_eth_rx_err':

> dpaa2-eth.c:(.text+0x3cec): undefined reference to `devlink_trap_report'

> drivers/net/ethernet/freescale/dpaa2/dpaa2-eth-devlink.o: in function `dpaa2_eth_dl_info_get':

> dpaa2-eth-devlink.c:(.text+0x160): undefined reference to `devlink_info_driver_name_put'

> 

> [...]


Here is the summary with links:
  - [net] dpaa2-eth: Fix compile error due to missing devlink support
    https://git.kernel.org/netdev/net/c/078eb55cdf25

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
diff mbox series

Patch

diff --git a/drivers/net/ethernet/freescale/dpaa2/Kconfig b/drivers/net/ethernet/freescale/dpaa2/Kconfig
index c0e05f71826d..ee7a906e30b3 100644
--- a/drivers/net/ethernet/freescale/dpaa2/Kconfig
+++ b/drivers/net/ethernet/freescale/dpaa2/Kconfig
@@ -5,6 +5,7 @@  config FSL_DPAA2_ETH
 	select PHYLINK
 	select PCS_LYNX
 	select FSL_XGMAC_MDIO
+	select NET_DEVLINK
 	help
 	  This is the DPAA2 Ethernet driver supporting Freescale SoCs
 	  with DPAA2 (DataPath Acceleration Architecture v2).