diff mbox series

[net-next,v2,1/2] ethtool: Add CMIS 4.0 module type to UAPI

Message ID 1606123198-6230-2-git-send-email-moshe@mellanox.com
State New
Headers show
Series Add support for DSFP transceiver type | expand

Commit Message

Moshe Shemesh Nov. 23, 2020, 9:19 a.m. UTC 
From: Vladyslav Tarasiuk <vladyslavt@nvidia.com>

CMIS 4.0 document describes a universal EEPROM memory layout, which is
used for some modules such as DSFP, OSFP and QSFP-DD modules. In order
to distinguish them in userspace from existing standards, add
corresponding values.

CMIS 4.0 EERPOM memory includes mandatory and optional pages, the max
read length 768B includes passive and active cables mandatory pages.

Signed-off-by: Vladyslav Tarasiuk <vladyslavt@nvidia.com>
Reviewed-by: Moshe Shemesh <moshe@nvidia.com>
---
 include/uapi/linux/ethtool.h | 3 +++
 1 file changed, 3 insertions(+)

Comments

Jesse Brandeburg Nov. 23, 2020, 10:40 p.m. UTC | #1 
Moshe Shemesh wrote:

> From: Vladyslav Tarasiuk <vladyslavt@nvidia.com>
> 
> CMIS 4.0 document describes a universal EEPROM memory layout, which is
> used for some modules such as DSFP, OSFP and QSFP-DD modules. In order
> to distinguish them in userspace from existing standards, add
> corresponding values.
> 
> CMIS 4.0 EERPOM memory includes mandatory and optional pages, the max

typo? s/EERPOM/EEPROM

> read length 768B includes passive and active cables mandatory pages.
> 
> Signed-off-by: Vladyslav Tarasiuk <vladyslavt@nvidia.com>
> Reviewed-by: Moshe Shemesh <moshe@nvidia.com>

rest was ok.
Moshe Shemesh Nov. 25, 2020, 10:41 a.m. UTC | #2 
On 11/24/2020 12:40 AM, Jesse Brandeburg wrote:
> External email: Use caution opening links or attachments

>

>

> Moshe Shemesh wrote:

>

>> From: Vladyslav Tarasiuk <vladyslavt@nvidia.com>

>>

>> CMIS 4.0 document describes a universal EEPROM memory layout, which is

>> used for some modules such as DSFP, OSFP and QSFP-DD modules. In order

>> to distinguish them in userspace from existing standards, add

>> corresponding values.

>>

>> CMIS 4.0 EERPOM memory includes mandatory and optional pages, the max

> typo? s/EERPOM/EEPROM

Right, thanks.
>

>> read length 768B includes passive and active cables mandatory pages.

>>

>> Signed-off-by: Vladyslav Tarasiuk <vladyslavt@nvidia.com>

>> Reviewed-by: Moshe Shemesh <moshe@nvidia.com>

> rest was ok.
diff mbox series

Patch

diff --git a/include/uapi/linux/ethtool.h b/include/uapi/linux/ethtool.h
index 9ca87bc73c44..0ec4c0ea3235 100644
--- a/include/uapi/linux/ethtool.h
+++ b/include/uapi/linux/ethtool.h
@@ -1861,9 +1861,12 @@  static inline int ethtool_validate_duplex(__u8 duplex)
 #define ETH_MODULE_SFF_8636_LEN		256
 #define ETH_MODULE_SFF_8436		0x4
 #define ETH_MODULE_SFF_8436_LEN		256
+#define ETH_MODULE_CMIS_4		0x5
+#define ETH_MODULE_CMIS_4_LEN		256
 
 #define ETH_MODULE_SFF_8636_MAX_LEN     640
 #define ETH_MODULE_SFF_8436_MAX_LEN     640
+#define ETH_MODULE_CMIS_4_MAX_LEN	768
 
 /* Reset flags */
 /* The reset() operation must clear the flags for the components which