[v3,10/15] remoteproc: Rename function rproc_actuate()

Message ID	20201126210642.897302-11-mathieu.poirier@linaro.org
State	New
Headers	show Delivered-To: patch@linaro.org Received-SPF: pass (google.com: domain of devicetree-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; From: Mathieu Poirier <mathieu.poirier@linaro.org> To: ohad@wizery.com, bjorn.andersson@linaro.org, robh+dt@kernel.org Cc: linux-remoteproc@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, arnaud.pouliquen@st.com Subject: [PATCH v3 10/15] remoteproc: Rename function rproc_actuate() Date: Thu, 26 Nov 2020 14:06:37 -0700 Message-Id: <20201126210642.897302-11-mathieu.poirier@linaro.org> In-Reply-To: <20201126210642.897302-1-mathieu.poirier@linaro.org> References: <20201126210642.897302-1-mathieu.poirier@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk
Series	remoteproc: Add support for detaching from rproc \| expand [v3,00/15] remoteproc: Add support for detaching from rproc [v3,01/15] dt-bindings: remoteproc: Add bindind to support autonomous processors [v3,02/15] remoteproc: Re-check state in rproc_shutdown() [v3,03/15] remoteproc: Remove useless check in rproc_del() [v3,04/15] remoteproc: Add new RPROC_ATTACHED state [v3,05/15] remoteproc: Properly represent the attached state [v3,06/15] remoteproc: Properly deal with a kernel panic when attached [v3,07/15] remoteproc: Add new detach() remoteproc operation [v3,08/15] remoteproc: Introduce function __rproc_detach() [v3,09/15] remoteproc: Introduce function rproc_detach() [v3,10/15] remoteproc: Rename function rproc_actuate() [v3,11/15] remoteproc: Add return value to function rproc_shutdown() [v3,12/15] remoteproc: Properly deal with a stop request when attached [v3,13/15] remoteproc: Properly deal with a start request when attached [v3,14/15] remoteproc: Properly deal with detach request [v3,15/15] remoteproc: Refactor rproc delete and cdev release path

Message ID

20201126210642.897302-11-mathieu.poirier@linaro.org

State

New

Headers

Received-SPF: pass (google.com: domain of devicetree-owner@vger.kernel.org
	designates 23.128.96.18 as permitted sender)
	client-ip=23.128.96.18; 
From: Mathieu Poirier <mathieu.poirier@linaro.org>
To: ohad@wizery.com, bjorn.andersson@linaro.org, robh+dt@kernel.org
Cc: linux-remoteproc@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org, arnaud.pouliquen@st.com
Subject: [PATCH v3 10/15] remoteproc: Rename function rproc_actuate()
Date: Thu, 26 Nov 2020 14:06:37 -0700
Message-Id: <20201126210642.897302-11-mathieu.poirier@linaro.org>
In-Reply-To: <20201126210642.897302-1-mathieu.poirier@linaro.org>
References: <20201126210642.897302-1-mathieu.poirier@linaro.org>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Precedence: bulk

Series

remoteproc: Add support for detaching from rproc | expand

Commit Message

Mathieu Poirier Nov. 26, 2020, 9:06 p.m. UTC

Align what was done for rproc_detach() by renaming function
rproc_actuate().  That way it is easier to figure out the
opposite of each functions.

Signed-off-by: Mathieu Poirier <mathieu.poirier@linaro.org>

Reviewed-by: Peng Fan <peng.fan@nxp.com>

Reviewed-by: Arnaud Pouliquen <arnaud.pouliquen@st.com>

---
 drivers/remoteproc/remoteproc_core.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

-- 
2.25.1

diff --git a/drivers/remoteproc/remoteproc_core.c b/drivers/remoteproc/remoteproc_core.c
index f5adf05762e9..b54f60cc3cbd 100644
--- a/drivers/remoteproc/remoteproc_core.c
+++ b/drivers/remoteproc/remoteproc_core.c
@@ -1416,7 +1416,7 @@  static int rproc_start(struct rproc *rproc, const struct firmware *fw)
 	return ret;
 }
 
-static int rproc_attach(struct rproc *rproc)
+static int __rproc_attach(struct rproc *rproc)
 {
 	struct device *dev = &rproc->dev;
 	int ret;
@@ -1541,7 +1541,7 @@  static int rproc_fw_boot(struct rproc *rproc, const struct firmware *fw)
  * Attach to remote processor - similar to rproc_fw_boot() but without
  * the steps that deal with the firmware image.
  */
-static int rproc_actuate(struct rproc *rproc)
+static int rproc_attach(struct rproc *rproc)
 {
 	struct device *dev = &rproc->dev;
 	int ret;
@@ -1581,7 +1581,7 @@  static int rproc_actuate(struct rproc *rproc)
 		goto clean_up_resources;
 	}
 
-	ret = rproc_attach(rproc);
+	ret = __rproc_attach(rproc);
 	if (ret)
 		goto clean_up_resources;
 
@@ -1825,7 +1825,7 @@  int rproc_boot(struct rproc *rproc)
 	if (rproc->state == RPROC_DETACHED) {
 		dev_info(dev, "attaching to %s\n", rproc->name);
 
-		ret = rproc_actuate(rproc);
+		ret = rproc_attach(rproc);
 	} else {
 		dev_info(dev, "powering up %s\n", rproc->name);
 
@@ -1916,7 +1916,7 @@  EXPORT_SYMBOL(rproc_shutdown);
  *
  * @rproc: the remote processor
  *
- * Detach a remote processor (previously attached to with rproc_actuate()).
+ * Detach a remote processor (previously attached to with rproc_attach()).
  *
  * In case @rproc is still being used by an additional user(s), then
  * this function will just decrement the power refcount and exit,

[v3,10/15] remoteproc: Rename function rproc_actuate()

Commit Message

Patch