| Message ID | 20201126053839.25889-2-stanley.chu@mediatek.com |
|---|---|
| State | Superseded |
| Headers | show |
| Series | Refine error history and introduce notify_event vop | expand |
On 2020-11-26 13:38, Stanley Chu wrote: > Add error history for abort event in UFS Device W-LUN. > Besides, use specified value as parameter of ufshcd_update_reg_hist() > to identify the aborted tag or LUNs. > > Signed-off-by: Stanley Chu <stanley.chu@mediatek.com> > --- > drivers/scsi/ufs/ufshcd.c | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c > index 0e5473d4699b..28e4def13f21 100644 > --- a/drivers/scsi/ufs/ufshcd.c > +++ b/drivers/scsi/ufs/ufshcd.c > @@ -6742,8 +6742,10 @@ static int ufshcd_abort(struct scsi_cmnd *cmd) > * To avoid these unnecessary/illegal step we skip to the last error > * handling stage: reset and restore. > */ > - if (lrbp->lun == UFS_UPIU_UFS_DEVICE_WLUN) > + if (lrbp->lun == UFS_UPIU_UFS_DEVICE_WLUN) { > + ufshcd_update_reg_hist(&hba->ufs_stats.task_abort, lrbp->lun); > return ufshcd_eh_host_reset_handler(cmd); > + } > > ufshcd_hold(hba, false); > reg = ufshcd_readl(hba, REG_UTP_TRANSFER_REQ_DOOR_BELL); > @@ -6767,7 +6769,7 @@ static int ufshcd_abort(struct scsi_cmnd *cmd) > */ > scsi_print_command(hba->lrb[tag].cmd); > if (!hba->req_abort_count) { > - ufshcd_update_reg_hist(&hba->ufs_stats.task_abort, 0); > + ufshcd_update_reg_hist(&hba->ufs_stats.task_abort, tag); > ufshcd_print_host_regs(hba); > ufshcd_print_host_state(hba); > ufshcd_print_pwr_info(hba); Reviewed-by: Can Guo <cang@codeaurora.org>
diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c index 0e5473d4699b..28e4def13f21 100644 --- a/drivers/scsi/ufs/ufshcd.c +++ b/drivers/scsi/ufs/ufshcd.c @@ -6742,8 +6742,10 @@ static int ufshcd_abort(struct scsi_cmnd *cmd) * To avoid these unnecessary/illegal step we skip to the last error * handling stage: reset and restore. */ - if (lrbp->lun == UFS_UPIU_UFS_DEVICE_WLUN) + if (lrbp->lun == UFS_UPIU_UFS_DEVICE_WLUN) { + ufshcd_update_reg_hist(&hba->ufs_stats.task_abort, lrbp->lun); return ufshcd_eh_host_reset_handler(cmd); + } ufshcd_hold(hba, false); reg = ufshcd_readl(hba, REG_UTP_TRANSFER_REQ_DOOR_BELL); @@ -6767,7 +6769,7 @@ static int ufshcd_abort(struct scsi_cmnd *cmd) */ scsi_print_command(hba->lrb[tag].cmd); if (!hba->req_abort_count) { - ufshcd_update_reg_hist(&hba->ufs_stats.task_abort, 0); + ufshcd_update_reg_hist(&hba->ufs_stats.task_abort, tag); ufshcd_print_host_regs(hba); ufshcd_print_host_state(hba); ufshcd_print_pwr_info(hba);
Add error history for abort event in UFS Device W-LUN. Besides, use specified value as parameter of ufshcd_update_reg_hist() to identify the aborted tag or LUNs. Signed-off-by: Stanley Chu <stanley.chu@mediatek.com> --- drivers/scsi/ufs/ufshcd.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-)