[10/18] ipu3-cio2: Rename ipu3-cio2.c to allow module to be built from multiple source files retaining ipu3-cio2 name

Message ID 20201130133129.1024662-11-djrscally@gmail.com
State New
Headers show
Series
  • Untitled series #83583
Related show

Commit Message

Daniel Scally Nov. 30, 2020, 1:31 p.m.
ipu3-cio2 driver needs extending with multiple files; rename the main
source file and specify the renamed file in Makefile to accommodate that.

Suggested-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Signed-off-by: Daniel Scally <djrscally@gmail.com>
---
Changes since RFC v3:

	- None

 drivers/media/pci/intel/ipu3/Makefile                          | 2 ++
 drivers/media/pci/intel/ipu3/{ipu3-cio2.c => ipu3-cio2-main.c} | 0
 2 files changed, 2 insertions(+)
 rename drivers/media/pci/intel/ipu3/{ipu3-cio2.c => ipu3-cio2-main.c} (100%)

Comments

Bingbu Cao Dec. 1, 2020, 6:56 a.m. | #1
I see there will be multiple files, but there will be no conflict if keep as the main
file name unchanged, right? If so, I prefer keep as it was.

On 11/30/20 9:31 PM, Daniel Scally wrote:
> ipu3-cio2 driver needs extending with multiple files; rename the main

> source file and specify the renamed file in Makefile to accommodate that.

> 

> Suggested-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>

> Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>

> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

> Signed-off-by: Daniel Scally <djrscally@gmail.com>

> ---

> Changes since RFC v3:

> 

> 	- None

> 

>  drivers/media/pci/intel/ipu3/Makefile                          | 2 ++

>  drivers/media/pci/intel/ipu3/{ipu3-cio2.c => ipu3-cio2-main.c} | 0

>  2 files changed, 2 insertions(+)

>  rename drivers/media/pci/intel/ipu3/{ipu3-cio2.c => ipu3-cio2-main.c} (100%)

> 

> diff --git a/drivers/media/pci/intel/ipu3/Makefile b/drivers/media/pci/intel/ipu3/Makefile

> index 98ddd5beafe0..429d516452e4 100644

> --- a/drivers/media/pci/intel/ipu3/Makefile

> +++ b/drivers/media/pci/intel/ipu3/Makefile

> @@ -1,2 +1,4 @@

>  # SPDX-License-Identifier: GPL-2.0-only

>  obj-$(CONFIG_VIDEO_IPU3_CIO2) += ipu3-cio2.o

> +

> +ipu3-cio2-y += ipu3-cio2-main.o

> diff --git a/drivers/media/pci/intel/ipu3/ipu3-cio2.c b/drivers/media/pci/intel/ipu3/ipu3-cio2-main.c

> similarity index 100%

> rename from drivers/media/pci/intel/ipu3/ipu3-cio2.c

> rename to drivers/media/pci/intel/ipu3/ipu3-cio2-main.c

> 


-- 
Best regards,
Bingbu Cao
Bingbu Cao Dec. 1, 2020, 7:07 a.m. | #2
On 12/1/20 2:56 PM, Bingbu Cao wrote:
> I see there will be multiple files, but there will be no conflict if keep as the main

> file name unchanged, right? If so, I prefer keep as it was.


Oops, I notice you try to build all the files into single module, so please ignore my
comment above.

> 

> On 11/30/20 9:31 PM, Daniel Scally wrote:

>> ipu3-cio2 driver needs extending with multiple files; rename the main

>> source file and specify the renamed file in Makefile to accommodate that.

>>

>> Suggested-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>

>> Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>

>> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

>> Signed-off-by: Daniel Scally <djrscally@gmail.com>

>> ---

>> Changes since RFC v3:

>>

>> 	- None

>>

>>  drivers/media/pci/intel/ipu3/Makefile                          | 2 ++

>>  drivers/media/pci/intel/ipu3/{ipu3-cio2.c => ipu3-cio2-main.c} | 0

>>  2 files changed, 2 insertions(+)

>>  rename drivers/media/pci/intel/ipu3/{ipu3-cio2.c => ipu3-cio2-main.c} (100%)

>>

>> diff --git a/drivers/media/pci/intel/ipu3/Makefile b/drivers/media/pci/intel/ipu3/Makefile

>> index 98ddd5beafe0..429d516452e4 100644

>> --- a/drivers/media/pci/intel/ipu3/Makefile

>> +++ b/drivers/media/pci/intel/ipu3/Makefile

>> @@ -1,2 +1,4 @@

>>  # SPDX-License-Identifier: GPL-2.0-only

>>  obj-$(CONFIG_VIDEO_IPU3_CIO2) += ipu3-cio2.o

>> +

>> +ipu3-cio2-y += ipu3-cio2-main.o

>> diff --git a/drivers/media/pci/intel/ipu3/ipu3-cio2.c b/drivers/media/pci/intel/ipu3/ipu3-cio2-main.c

>> similarity index 100%

>> rename from drivers/media/pci/intel/ipu3/ipu3-cio2.c

>> rename to drivers/media/pci/intel/ipu3/ipu3-cio2-main.c

>>

> 


-- 
Best regards,
Bingbu Cao

Patch

diff --git a/drivers/media/pci/intel/ipu3/Makefile b/drivers/media/pci/intel/ipu3/Makefile
index 98ddd5beafe0..429d516452e4 100644
--- a/drivers/media/pci/intel/ipu3/Makefile
+++ b/drivers/media/pci/intel/ipu3/Makefile
@@ -1,2 +1,4 @@ 
 # SPDX-License-Identifier: GPL-2.0-only
 obj-$(CONFIG_VIDEO_IPU3_CIO2) += ipu3-cio2.o
+
+ipu3-cio2-y += ipu3-cio2-main.o
diff --git a/drivers/media/pci/intel/ipu3/ipu3-cio2.c b/drivers/media/pci/intel/ipu3/ipu3-cio2-main.c
similarity index 100%
rename from drivers/media/pci/intel/ipu3/ipu3-cio2.c
rename to drivers/media/pci/intel/ipu3/ipu3-cio2-main.c