diff mbox series

[26/34] dpt_i2o: use DID_ERROR instead of INITIATOR_ERROR message

Message ID 20201202115249.37690-27-hare@suse.de
State Superseded
Headers show
Series None | expand

Commit Message

Hannes Reinecke Dec. 2, 2020, 11:52 a.m. UTC 
Change the error code for an invalid SCSI opcode to DID_ERROR;
INITIATOR_ERROR is a scsi parallel message which doesn't apply
for RAID HBAs.

Signed-off-by: Hannes Reinecke <hare@suse.de>
---
 drivers/scsi/dpt_i2o.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Christoph Hellwig Dec. 2, 2020, 4:35 p.m. UTC | #1 
On Wed, Dec 02, 2020 at 12:52:41PM +0100, Hannes Reinecke wrote:
> Change the error code for an invalid SCSI opcode to DID_ERROR;
> INITIATOR_ERROR is a scsi parallel message which doesn't apply
> for RAID HBAs.

Looks good,

Reviewed-by: Christoph Hellwig <hch@lst.de>
diff mbox series

Patch

diff --git a/drivers/scsi/dpt_i2o.c b/drivers/scsi/dpt_i2o.c
index 4251212acbbe..a18a4a08f049 100644
--- a/drivers/scsi/dpt_i2o.c
+++ b/drivers/scsi/dpt_i2o.c
@@ -2226,7 +2226,7 @@  static s32 adpt_scsi_to_i2o(adpt_hba* pHba, struct scsi_cmnd* cmd, struct adpt_d
 		default:
 			printk(KERN_WARNING"%s: scsi opcode 0x%x not supported.\n",
 			     pHba->name, cmd->cmnd[0]);
-			cmd->result = (DID_OK <<16) | (INITIATOR_ERROR << 8);
+			cmd->result = (DID_ERROR <<16);
 			cmd->scsi_done(cmd);
 			return 	0;
 		}