drm/amdgpu: fw_attestation: fix unused function warning

Message ID 20201204165128.3747878-1-arnd@kernel.org
State New
Headers show
Series
  • drm/amdgpu: fw_attestation: fix unused function warning
Related show

Commit Message

Arnd Bergmann Dec. 4, 2020, 4:51 p.m.
From: Arnd Bergmann <arnd@arndb.de>


Without debugfs, the compiler notices one function that is not used at
all:

drivers/gpu/drm/amd/amdgpu/amdgpu_fw_attestation.c:123:12: error: unused function 'amdgpu_is_fw_attestation_supported' [-Werror,-Wunused-function]

In fact the static const amdgpu_fw_attestation_debugfs_ops structure is
also unused here, but that warning is currently disabled.

Removing the #ifdef check does the right thing and leads to all of this
code to be dropped without warning.

Fixes: 19ae333001b3 ("drm/amdgpu: added support for psp fw attestation")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>

---
 drivers/gpu/drm/amd/amdgpu/amdgpu_fw_attestation.c | 2 --
 1 file changed, 2 deletions(-)

-- 
2.27.0

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

Comments

Alex Deucher Dec. 4, 2020, 8:56 p.m. | #1
On Fri, Dec 4, 2020 at 11:51 AM Arnd Bergmann <arnd@kernel.org> wrote:
>

> From: Arnd Bergmann <arnd@arndb.de>

>

> Without debugfs, the compiler notices one function that is not used at

> all:

>

> drivers/gpu/drm/amd/amdgpu/amdgpu_fw_attestation.c:123:12: error: unused function 'amdgpu_is_fw_attestation_supported' [-Werror,-Wunused-function]

>

> In fact the static const amdgpu_fw_attestation_debugfs_ops structure is

> also unused here, but that warning is currently disabled.

>

> Removing the #ifdef check does the right thing and leads to all of this

> code to be dropped without warning.

>

> Fixes: 19ae333001b3 ("drm/amdgpu: added support for psp fw attestation")

> Signed-off-by: Arnd Bergmann <arnd@arndb.de>


Applied.  Thanks!

Alex

> ---

>  drivers/gpu/drm/amd/amdgpu/amdgpu_fw_attestation.c | 2 --

>  1 file changed, 2 deletions(-)

>

> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_fw_attestation.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_fw_attestation.c

> index e47bca1c7635..7c6e02e35573 100644

> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_fw_attestation.c

> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_fw_attestation.c

> @@ -130,7 +130,6 @@ static int amdgpu_is_fw_attestation_supported(struct amdgpu_device *adev)

>

>  void amdgpu_fw_attestation_debugfs_init(struct amdgpu_device *adev)

>  {

> -#if defined(CONFIG_DEBUG_FS)

>         if (!amdgpu_is_fw_attestation_supported(adev))

>                 return;

>

> @@ -139,5 +138,4 @@ void amdgpu_fw_attestation_debugfs_init(struct amdgpu_device *adev)

>                             adev_to_drm(adev)->primary->debugfs_root,

>                             adev,

>                             &amdgpu_fw_attestation_debugfs_ops);

> -#endif

>  }

> --

> 2.27.0

>

> _______________________________________________

> amd-gfx mailing list

> amd-gfx@lists.freedesktop.org

> https://lists.freedesktop.org/mailman/listinfo/amd-gfx

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

Patch

diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_fw_attestation.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_fw_attestation.c
index e47bca1c7635..7c6e02e35573 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_fw_attestation.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_fw_attestation.c
@@ -130,7 +130,6 @@  static int amdgpu_is_fw_attestation_supported(struct amdgpu_device *adev)
 
 void amdgpu_fw_attestation_debugfs_init(struct amdgpu_device *adev)
 {
-#if defined(CONFIG_DEBUG_FS)
 	if (!amdgpu_is_fw_attestation_supported(adev))
 		return;
 
@@ -139,5 +138,4 @@  void amdgpu_fw_attestation_debugfs_init(struct amdgpu_device *adev)
 			    adev_to_drm(adev)->primary->debugfs_root,
 			    adev,
 			    &amdgpu_fw_attestation_debugfs_ops);
-#endif
 }