| Message ID | 20201206190247.1861316-6-sam@ravnborg.org |
|---|---|
| State | New |
| Headers | show |
| Series | drivers/video: W=1 warning fixes | expand |
Hi "kernel test robot" On Sun, Dec 06, 2020 at 10:48:14PM +0100, Sam Ravnborg wrote: > commit aa1f4345b5480502a4e61addf5c59d606fdbce8f > Author: Sam Ravnborg <sam@ravnborg.org> > Date: Mon Nov 30 22:09:29 2020 +0100 > > sh: Fix set but not used warnings with !CONFIG_MMU > > Building fbdev drivers for sh with W=1 produces the following warning: > > tmiofb.c: In function ‘tmiofb_remove’: > tmiofb.c:805:21: warning: variable ‘par’ set but not used > > This is with allmodconfig and ARCH=sh > > This boiled down to iounmap() defined as empty for !CONFIG_MMU. > Fix this by by adding "(void)addr;" to tell the compiler the > argument to iounmap() should be considered used. > > v4: > - Fix build error of ethernet driver (kernel test robot) > Added missing () around macro parameter Thanks for thee quick report - it was easy to reproduce. I hope this is enough for the robot to pick up the updated patch. Sam
Am 06.12.20 um 20:02 schrieb Sam Ravnborg: > Building fbdev drivers for sh with W=1 produces the following warning: > > tmiofb.c: In function ‘tmiofb_remove’: > tmiofb.c:805:21: warning: variable ‘par’ set but not used > > This is with allmodconfig and ARCH=sh > > This boiled down to iounmap() defined as empty for !CONFIG_MMU. > Fix this by by adding "(void)addr;" to tell the compiler the > argument to iounmap() should be considered used. > > Signed-off-by: Sam Ravnborg <sam@ravnborg.org> > Cc: Thomas Zimmermann <tzimmermann@suse.de> > Cc: Lee Jones <lee.jones@linaro.org> > Cc: Rich Felker <dalias@libc.org> > Cc: Arnd Bergmann <arnd@arndb.de> > Cc: Geert Uytterhoeven <geert+renesas@glider.be> > Cc: Mike Rapoport <rppt@kernel.org> > Cc: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com> > Cc: Peter Zijlstra <peterz@infradead.org> > Cc: Sam Ravnborg <sam@ravnborg.org> > Cc: Andrew Morton <akpm@linux-foundation.org> Acked-by: Thomas Zimmermann <tzimmermann@suse.de> > --- > arch/sh/include/asm/io.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/sh/include/asm/io.h b/arch/sh/include/asm/io.h > index 6d5c6463bc07..5ad56c6c1e1e 100644 > --- a/arch/sh/include/asm/io.h > +++ b/arch/sh/include/asm/io.h > @@ -271,7 +271,7 @@ static inline void __iomem *ioremap_prot(phys_addr_t offset, unsigned long size, > #endif /* CONFIG_HAVE_IOREMAP_PROT */ > > #else /* CONFIG_MMU */ > -#define iounmap(addr) do { } while (0) > +#define iounmap(addr) do { (void)addr; } while (0) > #define ioremap(offset, size) ((void __iomem *)(unsigned long)(offset)) > #endif /* CONFIG_MMU */ > >
diff --git a/arch/sh/include/asm/io.h b/arch/sh/include/asm/io.h index 6d5c6463bc07..5ad56c6c1e1e 100644 --- a/arch/sh/include/asm/io.h +++ b/arch/sh/include/asm/io.h @@ -271,7 +271,7 @@ static inline void __iomem *ioremap_prot(phys_addr_t offset, unsigned long size, #endif /* CONFIG_HAVE_IOREMAP_PROT */ #else /* CONFIG_MMU */ -#define iounmap(addr) do { } while (0) +#define iounmap(addr) do { (void)addr; } while (0) #define ioremap(offset, size) ((void __iomem *)(unsigned long)(offset)) #endif /* CONFIG_MMU */
Building fbdev drivers for sh with W=1 produces the following warning: tmiofb.c: In function ‘tmiofb_remove’: tmiofb.c:805:21: warning: variable ‘par’ set but not used This is with allmodconfig and ARCH=sh This boiled down to iounmap() defined as empty for !CONFIG_MMU. Fix this by by adding "(void)addr;" to tell the compiler the argument to iounmap() should be considered used. Signed-off-by: Sam Ravnborg <sam@ravnborg.org> Cc: Thomas Zimmermann <tzimmermann@suse.de> Cc: Lee Jones <lee.jones@linaro.org> Cc: Rich Felker <dalias@libc.org> Cc: Arnd Bergmann <arnd@arndb.de> Cc: Geert Uytterhoeven <geert+renesas@glider.be> Cc: Mike Rapoport <rppt@kernel.org> Cc: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com> Cc: Peter Zijlstra <peterz@infradead.org> Cc: Sam Ravnborg <sam@ravnborg.org> Cc: Andrew Morton <akpm@linux-foundation.org> --- arch/sh/include/asm/io.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)