| Message ID | 20201206235919.393158-2-vladimir.oltean@nxp.com |
|---|---|
| State | New |
| Headers | show |
| Series | [RFC,net-next,01/13] RDMA/mlx4: remove bogus dev_base_lock usage | expand |
On Mon, Dec 07, 2020 at 01:59:07AM +0200, Vladimir Oltean wrote: > The dev_base_lock does not protect dev->dev_addr, so it serves no > purpose here. > > Cc: Leon Romanovsky <leon@kernel.org> > Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com> > --- > drivers/infiniband/hw/mlx4/main.c | 3 --- > 1 file changed, 3 deletions(-) Agree with the description, most likely the authors wanted to ensure that "dev" doesn't disappear, but it is not correct way to do and not needed in that flow. Thanks for the patch, Reviewed-by: Leon Romanovsky <leonro@nvidia.com>
diff --git a/drivers/infiniband/hw/mlx4/main.c b/drivers/infiniband/hw/mlx4/main.c index f0864f40ea1a..e3cd402c079a 100644 --- a/drivers/infiniband/hw/mlx4/main.c +++ b/drivers/infiniband/hw/mlx4/main.c @@ -2265,10 +2265,7 @@ static void mlx4_ib_update_qps(struct mlx4_ib_dev *ibdev, u64 release_mac = MLX4_IB_INVALID_MAC; struct mlx4_ib_qp *qp; - read_lock(&dev_base_lock); new_smac = mlx4_mac_to_u64(dev->dev_addr); - read_unlock(&dev_base_lock); - atomic64_set(&ibdev->iboe.mac[port - 1], new_smac); /* no need for update QP1 and mac registration in non-SRIOV */
The dev_base_lock does not protect dev->dev_addr, so it serves no purpose here. Cc: Leon Romanovsky <leon@kernel.org> Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com> --- drivers/infiniband/hw/mlx4/main.c | 3 --- 1 file changed, 3 deletions(-)