| Message ID | 20201207073346.16571-1-chiu@endlessos.org |
|---|---|
| State | New |
| Headers | show |
| Series | ALSA: hda/realtek - Add support for Memeza EDL03 headset mic | expand |
On Mon, Dec 7, 2020 at 4:38 PM Takashi Iwai <tiwai@suse.de> wrote: > > On Mon, 07 Dec 2020 08:33:46 +0100, > Chris Chiu wrote: > > > > The Memeza laptop EDL03 with codec ALC256 can't detect the headset > > microphone. The headphone jack sensing works after we add a pin > > definition for it by ALC256_FIXUP_ASUS_MIC_NO_PRESENCE. > > > > Signed-off-by: Chris Chiu <chiu@endlessos.org> > > Signed-off-by: Jian-Hong Pan <jhp@endlessos.org> > > --- > > sound/pci/hda/patch_realtek.c | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c > > index d5e4d0ba1008..8b9b94cfc67e 100644 > > --- a/sound/pci/hda/patch_realtek.c > > +++ b/sound/pci/hda/patch_realtek.c > > @@ -7871,6 +7871,7 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = { > > SND_PCI_QUIRK(0x10cf, 0x1629, "Lifebook U7x7", ALC255_FIXUP_LIFEBOOK_U7x7_HEADSET_MIC), > > SND_PCI_QUIRK(0x10cf, 0x1845, "Lifebook U904", ALC269_FIXUP_LIFEBOOK_EXTMIC), > > SND_PCI_QUIRK(0x10ec, 0x10f2, "Intel Reference board", ALC700_FIXUP_INTEL_REFERENCE), > > + SND_PCI_QUIRK(0x10ec, 0x115a, "Memeza EDL03", ALC256_FIXUP_ASUS_MIC_NO_PRESENCE), > > This looks suspicious. 10ec is the vendor ID for Realtek, i.e. it > implies that the BIOS on this machine didn't give the proper unique > ID. As you can see, the other entries with 10ec are only reference > boards. > > If the newer BIOS still doesn't fix the PCI SSID, you can check the > codec SSID instead. > > > thanks, > > Takashi Thanks for the feedback. This is a special case that the ODM didn't flash the DMI information and assign a formal SSID. They simply ship with the current status w/o any BIOS customization. I agree that we should push the vendor for a BIOS fix or figure out a generic solution for this instead of a pin quirk. Please ignore this. Thanks Chris
diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c index d5e4d0ba1008..8b9b94cfc67e 100644 --- a/sound/pci/hda/patch_realtek.c +++ b/sound/pci/hda/patch_realtek.c @@ -7871,6 +7871,7 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = { SND_PCI_QUIRK(0x10cf, 0x1629, "Lifebook U7x7", ALC255_FIXUP_LIFEBOOK_U7x7_HEADSET_MIC), SND_PCI_QUIRK(0x10cf, 0x1845, "Lifebook U904", ALC269_FIXUP_LIFEBOOK_EXTMIC), SND_PCI_QUIRK(0x10ec, 0x10f2, "Intel Reference board", ALC700_FIXUP_INTEL_REFERENCE), + SND_PCI_QUIRK(0x10ec, 0x115a, "Memeza EDL03", ALC256_FIXUP_ASUS_MIC_NO_PRESENCE), SND_PCI_QUIRK(0x10ec, 0x1230, "Intel Reference board", ALC295_FIXUP_CHROME_BOOK), SND_PCI_QUIRK(0x10f7, 0x8338, "Panasonic CF-SZ6", ALC269_FIXUP_HEADSET_MODE), SND_PCI_QUIRK(0x144d, 0xc109, "Samsung Ativ book 9 (NP900X3G)", ALC269_FIXUP_INV_DMIC),