diff mbox series

[2/2] media: camss: missing error code in msm_video_register()

Message ID X9Bz8pRFNhR2x11I@mwanda
State Accepted
Commit 9c67ed2ab299123872be14a3dc2ea44ce7e4538b
Headers show
Series [1/2] media: camss: Fix signedness bug in video_enum_fmt() | expand

Commit Message

Dan Carpenter Dec. 9, 2020, 6:51 a.m. UTC 
This error path returns success but it should return -EINVAL.

Fixes: cba3819d1e93 ("media: camss: Format configuration per hardware version")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
---
 drivers/media/platform/qcom/camss/camss-video.c | 1 +
 1 file changed, 1 insertion(+)
diff mbox series

Patch

diff --git a/drivers/media/platform/qcom/camss/camss-video.c b/drivers/media/platform/qcom/camss/camss-video.c
index 2fa3214775d5..97cea7c4d769 100644
--- a/drivers/media/platform/qcom/camss/camss-video.c
+++ b/drivers/media/platform/qcom/camss/camss-video.c
@@ -961,6 +961,7 @@  int msm_video_register(struct camss_video *video, struct v4l2_device *v4l2_dev,
 			video->nformats = ARRAY_SIZE(formats_rdi_8x96);
 		}
 	} else {
+		ret = -EINVAL;
 		goto error_video_register;
 	}