| Message ID | 1406027485-15657-3-git-send-email-lee.jones@linaro.org |
|---|---|
| State | Accepted |
| Commit | 4ed8f7182ed4c27e7190c3533e02937bac2f9df6 |
| Headers | show |
On Tue, Jul 22, 2014 at 4:41 PM, Lee Jones <lee.jones@linaro.org> wrote: > This is part of an effort to clean-up the MFD subsystem. > > WARNING: Missing a blank line after declarations > + int ret; > + ret = i2c_add_driver(&max8925_driver); > > total: 0 errors, 1 warnings, 275 lines checked > > Signed-off-by: Lee Jones <lee.jones@linaro.org> > --- > drivers/mfd/max8925-i2c.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/mfd/max8925-i2c.c b/drivers/mfd/max8925-i2c.c > index a83eed5..ecbe78e 100644 > --- a/drivers/mfd/max8925-i2c.c > +++ b/drivers/mfd/max8925-i2c.c > @@ -257,9 +257,11 @@ static struct i2c_driver max8925_driver = { > static int __init max8925_i2c_init(void) > { > int ret; > + > ret = i2c_add_driver(&max8925_driver); > if (ret != 0) > pr_err("Failed to register MAX8925 I2C driver: %d\n", ret); > + There are more such changes required in this file. If they could go with this, will be good. > return ret; > } > subsys_initcall(max8925_i2c_init); > -- > 1.8.3.2 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/
On Tue, 22 Jul 2014, pramod gurav wrote: > On Tue, Jul 22, 2014 at 4:41 PM, Lee Jones <lee.jones@linaro.org> wrote: > > This is part of an effort to clean-up the MFD subsystem. > > > > WARNING: Missing a blank line after declarations > > + int ret; > > + ret = i2c_add_driver(&max8925_driver); > > > > total: 0 errors, 1 warnings, 275 lines checked > > > > Signed-off-by: Lee Jones <lee.jones@linaro.org> > > --- > > drivers/mfd/max8925-i2c.c | 2 ++ > > 1 file changed, 2 insertions(+) > > > > diff --git a/drivers/mfd/max8925-i2c.c b/drivers/mfd/max8925-i2c.c > > index a83eed5..ecbe78e 100644 > > --- a/drivers/mfd/max8925-i2c.c > > +++ b/drivers/mfd/max8925-i2c.c > > @@ -257,9 +257,11 @@ static struct i2c_driver max8925_driver = { > > static int __init max8925_i2c_init(void) > > { > > int ret; > > + > > ret = i2c_add_driver(&max8925_driver); > > if (ret != 0) > > pr_err("Failed to register MAX8925 I2C driver: %d\n", ret); > > + > There are more such changes required in this file. If they could go > with this, will be good. Checkpatch only found this one: > WARNING: Missing a blank line after declarations > #260: FILE: drivers/mfd/max8925-i2c.c:260: > + int ret; > + ret = i2c_add_driver(&max8925_driver); > > total: 0 errors, 1 warnings, 275 lines checked Can you point me to the others please?
diff --git a/drivers/mfd/max8925-i2c.c b/drivers/mfd/max8925-i2c.c index a83eed5..ecbe78e 100644 --- a/drivers/mfd/max8925-i2c.c +++ b/drivers/mfd/max8925-i2c.c @@ -257,9 +257,11 @@ static struct i2c_driver max8925_driver = { static int __init max8925_i2c_init(void) { int ret; + ret = i2c_add_driver(&max8925_driver); if (ret != 0) pr_err("Failed to register MAX8925 I2C driver: %d\n", ret); + return ret; } subsys_initcall(max8925_i2c_init);
This is part of an effort to clean-up the MFD subsystem. WARNING: Missing a blank line after declarations + int ret; + ret = i2c_add_driver(&max8925_driver); total: 0 errors, 1 warnings, 275 lines checked Signed-off-by: Lee Jones <lee.jones@linaro.org> --- drivers/mfd/max8925-i2c.c | 2 ++ 1 file changed, 2 insertions(+)