DTS: ARM: gta04: remove legacy spi-cs-high to make display work again

Message ID de8774e44a8f6402435e64034b8e7122157f5b52.1607766924.git.hns@goldelico.com
State New
Headers show
Series
  • DTS: ARM: gta04: remove legacy spi-cs-high to make display work again
Related show

Commit Message

H. Nikolaus Schaller Dec. 12, 2020, 9:55 a.m.
This reverts

commit f1f028ff89cb ("DTS: ARM: gta04: introduce legacy spi-cs-high to make display work again")

which had to be intruduced after

commit 6953c57ab172 ("gpio: of: Handle SPI chipselect legacy bindings")

broke the GTA04 display. This contradicted the data sheet but was the only
way to get it as an spi client operational again.

The panel data sheet defines the chip-select to be active low.

Now, with the arrival of

commit 766c6b63aa04 ("spi: fix client driver breakages when using GPIO descriptors")

the logic of interaction between spi-cs-high and the gpio descriptor flags
has been changed a second time, making the display broken again. So we have
to remove the original fix which in retrospect was a workaround of a bug in
the spi subsystem and not a feature of the panel or bug in the device tree.

With this fix the device tree is back in sync with the data sheet and
spi subsystem code.

Fixes: 766c6b63aa04 ("spi: fix client driver breakages when using GPIO descriptors")
CC: stable@vger.kernel.org
Signed-off-by: H. Nikolaus Schaller <hns@goldelico.com>
---
 arch/arm/boot/dts/omap3-gta04.dtsi | 1 -
 1 file changed, 1 deletion(-)

Comments

Tony Lindgren Dec. 18, 2020, 7:12 a.m. | #1
* H. Nikolaus Schaller <hns@goldelico.com> [201212 11:59]:
> This reverts

> 

> commit f1f028ff89cb ("DTS: ARM: gta04: introduce legacy spi-cs-high to make display work again")

> 

> which had to be intruduced after

> 

> commit 6953c57ab172 ("gpio: of: Handle SPI chipselect legacy bindings")

> 

> broke the GTA04 display. This contradicted the data sheet but was the only

> way to get it as an spi client operational again.

> 

> The panel data sheet defines the chip-select to be active low.

> 

> Now, with the arrival of

> 

> commit 766c6b63aa04 ("spi: fix client driver breakages when using GPIO descriptors")

> 

> the logic of interaction between spi-cs-high and the gpio descriptor flags

> has been changed a second time, making the display broken again. So we have

> to remove the original fix which in retrospect was a workaround of a bug in

> the spi subsystem and not a feature of the panel or bug in the device tree.

> 

> With this fix the device tree is back in sync with the data sheet and

> spi subsystem code.


Thanks applying into fixes.

Tony

Patch

diff --git a/arch/arm/boot/dts/omap3-gta04.dtsi b/arch/arm/boot/dts/omap3-gta04.dtsi
index c8745bc800f71..003202d129907 100644
--- a/arch/arm/boot/dts/omap3-gta04.dtsi
+++ b/arch/arm/boot/dts/omap3-gta04.dtsi
@@ -124,7 +124,6 @@  lcd: td028ttec1@0 {
 			spi-max-frequency = <100000>;
 			spi-cpol;
 			spi-cpha;
-			spi-cs-high;
 
 			backlight= <&backlight>;
 			label = "lcd";