diff mbox series

scsi: megaraid: fix ifnullfree.cocci warnings

Message ID alpine.DEB.2.22.394.2012111113060.2669@hadrien
State New
Headers show
Series scsi: megaraid: fix ifnullfree.cocci warnings | expand

Commit Message

Julia Lawall Dec. 11, 2020, 10:16 a.m. UTC 
From: kernel test robot <lkp@intel.com>

NULL check before vfree is not needed.

Generated by: scripts/coccinelle/free/ifnullfree.cocci

Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: kernel test robot <lkp@intel.com>
Signed-off-by: Julia Lawall <julia.lawall@inria.fr>
---

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head:   33dc9614dc208291d0c4bcdeb5d30d481dcd2c4c
commit: 5e0c074e5b4be02d57d1b60abc3391afe7edd088 coccinelle: ifnullfree: add vfree(), kvfree*() functions
:::::: branch date: 3 hours ago
:::::: commit date: 3 months ago

Please take the patch only if it's a positive warning. Thanks!

 megaraid_sas_fusion.c |    3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

Comments

Martin K. Petersen Jan. 23, 2021, 3:25 a.m. UTC | #1 
Julia,

> NULL check before vfree is not needed.

>

> Generated by: scripts/coccinelle/free/ifnullfree.cocci


Applied to 5.12/scsi-staging, thanks!

-- 
Martin K. Petersen	Oracle Linux Engineering
Martin K. Petersen Jan. 27, 2021, 4:54 a.m. UTC | #2 
On Fri, 11 Dec 2020 11:16:15 +0100 (CET), Julia Lawall wrote:

> NULL check before vfree is not needed.

> 

> Generated by: scripts/coccinelle/free/ifnullfree.cocci


Applied to 5.12/scsi-queue, thanks!

[1/1] scsi: megaraid: fix ifnullfree.cocci warnings
      https://git.kernel.org/mkp/scsi/c/12e3ef8b3e7c

-- 
Martin K. Petersen	Oracle Linux Engineering
diff mbox series

Patch

--- a/drivers/scsi/megaraid/megaraid_sas_fusion.c
+++ b/drivers/scsi/megaraid/megaraid_sas_fusion.c
@@ -3917,8 +3917,7 @@  megasas_free_host_crash_buffer(struct me
 {
 	unsigned int i;
 	for (i = 0; i < instance->drv_buf_alloc; i++) {
-		if (instance->crash_buf[i])
-			vfree(instance->crash_buf[i]);
+		vfree(instance->crash_buf[i]);
 	}
 	instance->drv_buf_index = 0;
 	instance->drv_buf_alloc = 0;