From patchwork Fri Jul 25 20:24:39 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: dann frazier X-Patchwork-Id: 34321 Return-Path: X-Original-To: linaro@patches.linaro.org Delivered-To: linaro@patches.linaro.org Received: from mail-oi0-f69.google.com (mail-oi0-f69.google.com [209.85.218.69]) by ip-10-151-82-157.ec2.internal (Postfix) with ESMTPS id 65C59235AB for ; Fri, 25 Jul 2014 20:33:26 +0000 (UTC) Received: by mail-oi0-f69.google.com with SMTP id h136sf19490287oig.8 for ; Fri, 25 Jul 2014 13:33:25 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:delivered-to:date:from:to:cc:subject:message-id :mime-version:user-agent:sender:precedence:list-id:x-original-sender :x-original-authentication-results:mailing-list:list-post:list-help :list-archive:list-unsubscribe:content-type:content-disposition; bh=M+H/Ft7UppW0LeSSgKxC3xAgoVUQ/N0CcS/CfdF62ZY=; b=EnpalCgWmQ41LFOYsfPBtKTpOEhNX0CM+SJXE1gt9EXccBYr7+lBgjS9Spwn9pfGKc GBE02MFHT+ibTcow0BqQjbSvTzwf3k5AyUxQd2lNy722Uex48F8xCk06RDbUR+N1Xg0s ckwHjbnHz83BWbvjX/iq1D2OULLpoxOUasMRqrAwwbJP3b0zptHdjz93FhnhJnPwUIsM ikDBOZ0kFKdHpK5422ts8Vnc8FynV8nUHE/BpXG/orKcUZIWdLJIBvxhETvPWJHIEEHe qfI2LblHlMtpAe7ucgxVwArQSac4uPeIpBkFRn8+NzGs00rsuCQvgHtMiX+WPhF7ioQY uYDQ== X-Gm-Message-State: ALoCoQkWrbcuYQ2OIEjTHvL0+lPitgemW45yV9GYiuA37x0WcyN/iYqeKVs8ghpXDFjYSJa4fBJe X-Received: by 10.42.177.5 with SMTP id bg5mr9569601icb.27.1406320405925; Fri, 25 Jul 2014 13:33:25 -0700 (PDT) X-BeenThere: patchwork-forward@linaro.org Received: by 10.140.50.77 with SMTP id r71ls1428270qga.71.gmail; Fri, 25 Jul 2014 13:33:25 -0700 (PDT) X-Received: by 10.220.137.145 with SMTP id w17mr5448386vct.47.1406320405777; Fri, 25 Jul 2014 13:33:25 -0700 (PDT) Received: from mail-vc0-f172.google.com (mail-vc0-f172.google.com [209.85.220.172]) by mx.google.com with ESMTPS id z8si8296821ven.51.2014.07.25.13.33.25 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Fri, 25 Jul 2014 13:33:25 -0700 (PDT) Received-SPF: pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.220.172 as permitted sender) client-ip=209.85.220.172; Received: by mail-vc0-f172.google.com with SMTP id im17so8262660vcb.17 for ; Fri, 25 Jul 2014 13:33:25 -0700 (PDT) X-Received: by 10.221.34.13 with SMTP id sq13mr24378965vcb.16.1406320405592; Fri, 25 Jul 2014 13:33:25 -0700 (PDT) X-Forwarded-To: patchwork-forward@linaro.org X-Forwarded-For: patch@linaro.org patchwork-forward@linaro.org Delivered-To: patch@linaro.org Received: by 10.221.37.5 with SMTP id tc5csp64550vcb; Fri, 25 Jul 2014 13:33:25 -0700 (PDT) X-Received: by 10.66.102.73 with SMTP id fm9mr21684053pab.72.1406320404779; Fri, 25 Jul 2014 13:33:24 -0700 (PDT) Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id sk7si10304074pab.106.2014.07.25.13.33.23 for ; Fri, 25 Jul 2014 13:33:24 -0700 (PDT) Received-SPF: none (google.com: linux-gpio-owner@vger.kernel.org does not designate permitted sender hosts) client-ip=209.132.180.67; Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753729AbaGYUdX (ORCPT + 1 other); Fri, 25 Jul 2014 16:33:23 -0400 Received: from complete.lackof.org ([198.49.126.79]:60543 "EHLO complete.lackof.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753354AbaGYUdW (ORCPT ); Fri, 25 Jul 2014 16:33:22 -0400 X-Greylist: delayed 522 seconds by postgrey-1.27 at vger.kernel.org; Fri, 25 Jul 2014 16:33:22 EDT Received: from localhost (c-50-170-238-85.hsd1.co.comcast.net [50.170.238.85]) (using TLSv1 with cipher AES128-SHA (128/128 bits)) (Client did not present a certificate) by complete.lackof.org (Postfix) with ESMTPSA id B792933E0065; Fri, 25 Jul 2014 14:24:39 -0600 (MDT) Date: Fri, 25 Jul 2014 14:24:39 -0600 From: dann frazier To: stable@vger.kernel.org Cc: Sebastian Andrzej Siewior , Alan Tull , Linus Walleij , Alexandre Courbot , linux-gpio@vger.kernel.org Subject: [PATCH 3.15] gpio: dwapb: drop irq_setup_generic_chip() Message-ID: <20140725202439.GA22536@fluid.dannf> MIME-Version: 1.0 User-Agent: Mutt/1.5.23 (2014-03-12) X-Virus-Scanned: clamav-milter 0.98.1 at complete.lackof.org X-Virus-Status: Clean X-Spam-Status: No, score=0.0 required=5.0 tests=UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on complete.lackof.org Sender: linux-gpio-owner@vger.kernel.org Precedence: list List-ID: X-Mailing-List: linux-gpio@vger.kernel.org X-Removed-Original-Auth: Dkim didn't pass. X-Original-Sender: dann.frazier@canonical.com X-Original-Authentication-Results: mx.google.com; spf=pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.220.172 as permitted sender) smtp.mail=patch+caf_=patchwork-forward=linaro.org@linaro.org Mailing-list: list patchwork-forward@linaro.org; contact patchwork-forward+owners@linaro.org X-Google-Group-Id: 836684582541 List-Post: , List-Help: , List-Archive: List-Unsubscribe: , Content-Disposition: inline From: Sebastian Andrzej Siewior commit 11d3d334af07408ce3a68860c40006ddcd343da5 upstream. The driver calls irq_alloc_domain_generic_chips() which creates a gc and adds it to gc_list. The driver later then calls irq_setup_generic_chip() which also initializes the gc and adds it to the gc_list() and this corrupts the list. Enable LIST_DEBUG and you see the kernel complain. This isn't required, irq_alloc_domain_generic_chips() did the init. Signed-off-by: Sebastian Andrzej Siewior Tested-by: Alan Tull Signed-off-by: Linus Walleij Signed-off-by: dann frazier Cc: # 3.15.x --- drivers/gpio/gpio-dwapb.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/gpio/gpio-dwapb.c b/drivers/gpio/gpio-dwapb.c index ed5711f..4d25a06b 100644 --- a/drivers/gpio/gpio-dwapb.c +++ b/drivers/gpio/gpio-dwapb.c @@ -260,9 +260,6 @@ static void dwapb_configure_irqs(struct dwapb_gpio *gpio, ct->regs.ack = GPIO_PORTA_EOI; ct->regs.mask = GPIO_INTMASK; - irq_setup_generic_chip(irq_gc, IRQ_MSK(port->bgc.gc.ngpio), - IRQ_GC_INIT_NESTED_LOCK, IRQ_NOREQUEST, 0); - irq_set_chained_handler(irq, dwapb_irq_handler); irq_set_handler_data(irq, gpio);