diff mbox

regulator: lp872x: Don't set constraints within the regulator driver

Message ID 1406547220-2750-1-git-send-email-broonie@kernel.org
State New
Headers show

Commit Message

Mark Brown July 28, 2014, 11:33 a.m. UTC 
From: Mark Brown <broonie@linaro.org>

Regulator drivers should not be specifying constraints since the valid
configurations depend on how the device is used in a given system, there
is no way to know if a configuration is safe for a given board.

Signed-off-by: Mark Brown <broonie@linaro.org>
---
 drivers/regulator/lp872x.c | 8 --------
 1 file changed, 8 deletions(-)
diff mbox

Patch

diff --git a/drivers/regulator/lp872x.c b/drivers/regulator/lp872x.c
index 2e022aabd951..954616f16c81 100644
--- a/drivers/regulator/lp872x.c
+++ b/drivers/regulator/lp872x.c
@@ -892,14 +892,6 @@  static struct lp872x_platform_data
 		pdata->regulator_data[i].id =
 				(enum lp872x_regulator_id)match[i].driver_data;
 		pdata->regulator_data[i].init_data = match[i].init_data;
-
-		/* Operation mode configuration for buck/buck1/buck2 */
-		if (strncmp(match[i].name, "buck", 4))
-			continue;
-
-		d = pdata->regulator_data[i].init_data;
-		d->constraints.valid_modes_mask |= LP872X_VALID_OPMODE;
-		d->constraints.valid_ops_mask |= REGULATOR_CHANGE_MODE;
 	}
 out:
 	return pdata;