| Message ID | 20201214112157.4841-1-tklauser@distanz.ch |
|---|---|
| State | Superseded |
| Headers | show |
| Series | devlink: use _BITUL() macro instead of BIT() in the UAPI header | expand |
On Mon, 14 Dec 2020 12:21:57 +0100 Tobias Klauser wrote: > The BIT() macro is not available for the UAPI headers. Moreover, it can > be defined differently in user space headers. Thus, replace its usage > with the _BITUL() macro which is already used in other macro definitions > in <linux/devlink.h>. > > Fixes: dc64cc7c6310 ("devlink: Add devlink reload limit option") > Signed-off-by: Tobias Klauser <tklauser@distanz.ch> Thanks for the patch. It doesn't apply any longer, please respin on top of: https://git.kernel.org/pub/scm/linux/kernel/git/netdev/net-next.git/ Thanks!
diff --git a/include/uapi/linux/devlink.h b/include/uapi/linux/devlink.h index 5203f54a2be1..cf89c318f2ac 100644 --- a/include/uapi/linux/devlink.h +++ b/include/uapi/linux/devlink.h @@ -322,7 +322,7 @@ enum devlink_reload_limit { DEVLINK_RELOAD_LIMIT_MAX = __DEVLINK_RELOAD_LIMIT_MAX - 1 }; -#define DEVLINK_RELOAD_LIMITS_VALID_MASK (BIT(__DEVLINK_RELOAD_LIMIT_MAX) - 1) +#define DEVLINK_RELOAD_LIMITS_VALID_MASK (_BITUL(__DEVLINK_RELOAD_LIMIT_MAX) - 1) enum devlink_attr { /* don't change the order or add anything between, this is ABI! */
The BIT() macro is not available for the UAPI headers. Moreover, it can be defined differently in user space headers. Thus, replace its usage with the _BITUL() macro which is already used in other macro definitions in <linux/devlink.h>. Fixes: dc64cc7c6310 ("devlink: Add devlink reload limit option") Signed-off-by: Tobias Klauser <tklauser@distanz.ch> --- include/uapi/linux/devlink.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)