diff mbox series

[v3] driver: aspeed: g6: Fix PWMG0 pinctrl setting

Message ID 20201217024912.3198-1-billy_tsai@aspeedtech.com
State Accepted
Commit 92ff62a7bcc17d47c0ce8dddfb7a6e1a2e55ebf4
Headers show
Series [v3] driver: aspeed: g6: Fix PWMG0 pinctrl setting | expand

Commit Message

Billy Tsai Dec. 17, 2020, 2:49 a.m. UTC
The SCU offset for signal PWM8 in group PWM8G0 is wrong, fix it from
SCU414 to SCU4B4.

Signed-off-by: Billy Tsai <billy_tsai@aspeedtech.com>
---
 drivers/pinctrl/aspeed/pinctrl-aspeed-g6.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Andrew Jeffery Dec. 18, 2020, 2:03 a.m. UTC | #1
On Thu, 17 Dec 2020, at 13:19, Billy Tsai wrote:
> The SCU offset for signal PWM8 in group PWM8G0 is wrong, fix it from

> SCU414 to SCU4B4.

> 

> Signed-off-by: Billy Tsai <billy_tsai@aspeedtech.com>


Reviewed-by: Andrew Jeffery <andrew@aj.id.au>


Thanks Billy.

> ---

>  drivers/pinctrl/aspeed/pinctrl-aspeed-g6.c | 2 +-

>  1 file changed, 1 insertion(+), 1 deletion(-)

> 

> diff --git a/drivers/pinctrl/aspeed/pinctrl-aspeed-g6.c 

> b/drivers/pinctrl/aspeed/pinctrl-aspeed-g6.c

> index b673a44ffa3b..aa53e9d3489b 100644

> --- a/drivers/pinctrl/aspeed/pinctrl-aspeed-g6.c

> +++ b/drivers/pinctrl/aspeed/pinctrl-aspeed-g6.c

> @@ -367,7 +367,7 @@ FUNC_GROUP_DECL(RMII4, F24, E23, E24, E25, C25, 

> C24, B26, B25, B24);

>  

>  #define D22 40

>  SIG_EXPR_LIST_DECL_SESG(D22, SD1CLK, SD1, SIG_DESC_SET(SCU414, 8));

> -SIG_EXPR_LIST_DECL_SEMG(D22, PWM8, PWM8G0, PWM8, SIG_DESC_SET(SCU414, 8));

> +SIG_EXPR_LIST_DECL_SEMG(D22, PWM8, PWM8G0, PWM8, SIG_DESC_SET(SCU4B4, 8));

>  PIN_DECL_2(D22, GPIOF0, SD1CLK, PWM8);

>  GROUP_DECL(PWM8G0, D22);

>  

> -- 

> 2.17.1

> 

>
Linus Walleij Jan. 4, 2021, 3:03 p.m. UTC | #2
On Thu, Dec 17, 2020 at 3:50 AM Billy Tsai <billy_tsai@aspeedtech.com> wrote:

> The SCU offset for signal PWM8 in group PWM8G0 is wrong, fix it from

> SCU414 to SCU4B4.

>

> Signed-off-by: Billy Tsai <billy_tsai@aspeedtech.com>


Patch applied for fixes.

Yours,
Linus Walleij
diff mbox series

Patch

diff --git a/drivers/pinctrl/aspeed/pinctrl-aspeed-g6.c b/drivers/pinctrl/aspeed/pinctrl-aspeed-g6.c
index b673a44ffa3b..aa53e9d3489b 100644
--- a/drivers/pinctrl/aspeed/pinctrl-aspeed-g6.c
+++ b/drivers/pinctrl/aspeed/pinctrl-aspeed-g6.c
@@ -367,7 +367,7 @@  FUNC_GROUP_DECL(RMII4, F24, E23, E24, E25, C25, C24, B26, B25, B24);
 
 #define D22 40
 SIG_EXPR_LIST_DECL_SESG(D22, SD1CLK, SD1, SIG_DESC_SET(SCU414, 8));
-SIG_EXPR_LIST_DECL_SEMG(D22, PWM8, PWM8G0, PWM8, SIG_DESC_SET(SCU414, 8));
+SIG_EXPR_LIST_DECL_SEMG(D22, PWM8, PWM8G0, PWM8, SIG_DESC_SET(SCU4B4, 8));
 PIN_DECL_2(D22, GPIOF0, SD1CLK, PWM8);
 GROUP_DECL(PWM8G0, D22);