diff mbox series

[2/4] hung_task: Replace "did_panic" with is_be_panic()

Message ID 20201218114406.61906-3-nixiaoming@huawei.com
State New
Headers show
Series Add new API is_being_panic() | expand

Commit Message

Xiaoming Ni Dec. 18, 2020, 11:44 a.m. UTC 
Replace the global variable "did_panic" with is_be_panic()

Signed-off-by: Xiaoming Ni <nixiaoming@huawei.com>
---
 kernel/hung_task.c | 17 +----------------
 1 file changed, 1 insertion(+), 16 deletions(-)

Comments

Pavel Machek Dec. 18, 2020, 12:59 p.m. UTC | #1 
On Fri 2020-12-18 19:44:04, Xiaoming Ni wrote:
> Replace the global variable "did_panic" with is_be_panic()

Changelog does not match patch.

Plus.. is_being_panic is not really english. "is_paniccing" would be
closer...?

Best regards,
								Pavel
Randy Dunlap Dec. 18, 2020, 5:06 p.m. UTC | #2 
On 12/18/20 6:36 AM, Tetsuo Handa wrote:
> On 2020/12/18 21:59, Pavel Machek wrote:
>> On Fri 2020-12-18 19:44:04, Xiaoming Ni wrote:
>> Plus.. is_being_panic is not really english. "is_paniccing" would be
>> closer...?
> 
> Or in_panic() ?
> 

Yes, or  in_panic_state()
Xiaoming Ni Dec. 20, 2020, 2:58 a.m. UTC | #3 
On 2020/12/19 1:06, Randy Dunlap wrote:
> On 12/18/20 6:36 AM, Tetsuo Handa wrote:

>> On 2020/12/18 21:59, Pavel Machek wrote:

>>> On Fri 2020-12-18 19:44:04, Xiaoming Ni wrote:

>>> Plus.. is_being_panic is not really english. "is_paniccing" would be

>>> closer...?

>>

>> Or in_panic() ?

>>

> 

> Yes, or  in_panic_state()

> 


Thank you,
I'll resend the patch later on according to your suggestion.

Thanks
Xiaoming Ni
.
diff mbox series

Patch

diff --git a/kernel/hung_task.c b/kernel/hung_task.c
index bb2e3e15c84c..3374b993da4c 100644
--- a/kernel/hung_task.c
+++ b/kernel/hung_task.c
@@ -50,7 +50,6 @@  unsigned long __read_mostly sysctl_hung_task_check_interval_secs;
 
 int __read_mostly sysctl_hung_task_warnings = 10;
 
-static int __read_mostly did_panic;
 static bool hung_task_show_lock;
 static bool hung_task_call_panic;
 static bool hung_task_show_all_bt;
@@ -72,18 +71,6 @@  unsigned int __read_mostly sysctl_hung_task_all_cpu_backtrace;
 unsigned int __read_mostly sysctl_hung_task_panic =
 				CONFIG_BOOTPARAM_HUNG_TASK_PANIC_VALUE;
 
-static int
-hung_task_panic(struct notifier_block *this, unsigned long event, void *ptr)
-{
-	did_panic = 1;
-
-	return NOTIFY_DONE;
-}
-
-static struct notifier_block panic_block = {
-	.notifier_call = hung_task_panic,
-};
-
 static void check_hung_task(struct task_struct *t, unsigned long timeout)
 {
 	unsigned long switch_count = t->nvcsw + t->nivcsw;
@@ -223,7 +210,7 @@  static void check_hung_uninterruptible_tasks(unsigned long timeout)
 	 * If the system crashed already then all bets are off,
 	 * do not report extra hung tasks:
 	 */
-	if (test_taint(TAINT_DIE) || did_panic)
+	if (test_taint(TAINT_DIE) || unlikely(is_being_panic()))
 		return;
 
 	hung_task_show_lock = false;
@@ -347,8 +334,6 @@  static int watchdog(void *dummy)
 
 static int __init hung_task_init(void)
 {
-	atomic_notifier_chain_register(&panic_notifier_list, &panic_block);
-
 	/* Disable hung task detector on suspend */
 	pm_notifier(hungtask_pm_notify, 0);