diff mbox series

[net] atm: idt77252: call pci_disable_device() on error path

Message ID X93dmC4NX0vbTpGp@mwanda
State New
Headers show
Series [net] atm: idt77252: call pci_disable_device() on error path | expand

Commit Message

Dan Carpenter Dec. 19, 2020, 11:01 a.m. UTC 
This error path needs to disable the pci device before returning.

Fixes: ede58ef28e10 ("atm: remove deprecated use of pci api")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
---
 drivers/atm/idt77252.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

patchwork-bot+netdevbpf@kernel.org Dec. 22, 2020, 1:40 a.m. UTC | #1 
Hello:

This patch was applied to netdev/net.git (refs/heads/master):

On Sat, 19 Dec 2020 14:01:44 +0300 you wrote:
> This error path needs to disable the pci device before returning.

> 

> Fixes: ede58ef28e10 ("atm: remove deprecated use of pci api")

> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>

> ---

>  drivers/atm/idt77252.c | 2 +-

>  1 file changed, 1 insertion(+), 1 deletion(-)


Here is the summary with links:
  - [net] atm: idt77252: call pci_disable_device() on error path
    https://git.kernel.org/netdev/net/c/8df66af5c1e5

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
diff mbox series

Patch

diff --git a/drivers/atm/idt77252.c b/drivers/atm/idt77252.c
index 65a3886f68c9..5f0472c18bcb 100644
--- a/drivers/atm/idt77252.c
+++ b/drivers/atm/idt77252.c
@@ -3607,7 +3607,7 @@  static int idt77252_init_one(struct pci_dev *pcidev,
 
 	if ((err = dma_set_mask_and_coherent(&pcidev->dev, DMA_BIT_MASK(32)))) {
 		printk("idt77252: can't enable DMA for PCI device at %s\n", pci_name(pcidev));
-		return err;
+		goto err_out_disable_pdev;
 	}
 
 	card = kzalloc(sizeof(struct idt77252_dev), GFP_KERNEL);