| Message ID | 20201221051320.18391-1-lukas.bulwahn@gmail.com |
|---|---|
| State | Accepted |
| Commit | c4151604f0603d5700072183a05828ff87d764e4 |
| Headers | show |
| Series | cpufreq: intel_pstate: remove obsolete functions | expand |
On Mon, Dec 21, 2020 at 11:21 PM Nathan Chancellor <natechancellor@gmail.com> wrote: > > On Mon, Dec 21, 2020 at 06:13:20AM +0100, Lukas Bulwahn wrote: > > percent_fp() was used in intel_pstate_pid_reset(), which was removed in > > commit 9d0ef7af1f2d ("cpufreq: intel_pstate: Do not use PID-based P-state > > selection") and hence, percent_fp() is unused since then. > > > > percent_ext_fp() was last used in intel_pstate_update_perf_limits(), which > > was refactored in commit 1a4fe38add8b ("cpufreq: intel_pstate: Remove > > max/min fractions to limit performance"), and hence, percent_ext_fp() is > > unused since then. > > > > make CC=clang W=1 points us those unused functions: > > > > drivers/cpufreq/intel_pstate.c:79:23: warning: unused function 'percent_fp' [-Wunused-function] > > static inline int32_t percent_fp(int percent) > > ^ > > > > drivers/cpufreq/intel_pstate.c:94:23: warning: unused function 'percent_ext_fp' [-Wunused-function] > > static inline int32_t percent_ext_fp(int percent) > > ^ > > > > Remove those obsolete functions. > > > > Signed-off-by: Lukas Bulwahn <lukas.bulwahn@gmail.com> > > Reviewed-by: Nathan Chancellor <natechancellor@gmail.com> > > > --- > > applies cleanly on current master and next-20201221 > > > > Srinivas, Len, Rafael, Viresh, please pick this minor non-urgent cleanup patch. > > > > drivers/cpufreq/intel_pstate.c | 10 ---------- > > 1 file changed, 10 deletions(-) > > > > diff --git a/drivers/cpufreq/intel_pstate.c b/drivers/cpufreq/intel_pstate.c > > index 2a4db856222f..0e35dd247986 100644 > > --- a/drivers/cpufreq/intel_pstate.c > > +++ b/drivers/cpufreq/intel_pstate.c > > @@ -76,11 +76,6 @@ static inline int ceiling_fp(int32_t x) > > return ret; > > } > > > > -static inline int32_t percent_fp(int percent) > > -{ > > - return div_fp(percent, 100); > > -} > > - > > static inline u64 mul_ext_fp(u64 x, u64 y) > > { > > return (x * y) >> EXT_FRAC_BITS; > > @@ -91,11 +86,6 @@ static inline u64 div_ext_fp(u64 x, u64 y) > > return div64_u64(x << EXT_FRAC_BITS, y); > > } > > > > -static inline int32_t percent_ext_fp(int percent) > > -{ > > - return div_ext_fp(percent, 100); > > -} > > - > > /** > > * struct sample - Store performance sample > > * @core_avg_perf: Ratio of APERF/MPERF which is the actual average > > -- Applied as 5.11-rc material, thanks!
diff --git a/drivers/cpufreq/intel_pstate.c b/drivers/cpufreq/intel_pstate.c index 2a4db856222f..0e35dd247986 100644 --- a/drivers/cpufreq/intel_pstate.c +++ b/drivers/cpufreq/intel_pstate.c @@ -76,11 +76,6 @@ static inline int ceiling_fp(int32_t x) return ret; } -static inline int32_t percent_fp(int percent) -{ - return div_fp(percent, 100); -} - static inline u64 mul_ext_fp(u64 x, u64 y) { return (x * y) >> EXT_FRAC_BITS; @@ -91,11 +86,6 @@ static inline u64 div_ext_fp(u64 x, u64 y) return div64_u64(x << EXT_FRAC_BITS, y); } -static inline int32_t percent_ext_fp(int percent) -{ - return div_ext_fp(percent, 100); -} - /** * struct sample - Store performance sample * @core_avg_perf: Ratio of APERF/MPERF which is the actual average
percent_fp() was used in intel_pstate_pid_reset(), which was removed in commit 9d0ef7af1f2d ("cpufreq: intel_pstate: Do not use PID-based P-state selection") and hence, percent_fp() is unused since then. percent_ext_fp() was last used in intel_pstate_update_perf_limits(), which was refactored in commit 1a4fe38add8b ("cpufreq: intel_pstate: Remove max/min fractions to limit performance"), and hence, percent_ext_fp() is unused since then. make CC=clang W=1 points us those unused functions: drivers/cpufreq/intel_pstate.c:79:23: warning: unused function 'percent_fp' [-Wunused-function] static inline int32_t percent_fp(int percent) ^ drivers/cpufreq/intel_pstate.c:94:23: warning: unused function 'percent_ext_fp' [-Wunused-function] static inline int32_t percent_ext_fp(int percent) ^ Remove those obsolete functions. Signed-off-by: Lukas Bulwahn <lukas.bulwahn@gmail.com> --- applies cleanly on current master and next-20201221 Srinivas, Len, Rafael, Viresh, please pick this minor non-urgent cleanup patch. drivers/cpufreq/intel_pstate.c | 10 ---------- 1 file changed, 10 deletions(-)