DTS: ARM: gta04: SPI panel chip select is active low

Message ID a539758e798631b54a85df102a1c6635e1f70b37.1608719420.git.hns@goldelico.com
State New
Headers show
Series
  • DTS: ARM: gta04: SPI panel chip select is active low
Related show

Commit Message

H. Nikolaus Schaller Dec. 23, 2020, 10:30 a.m.
With the arrival of

commit 2fee9583198eb9 ("spi: dt-bindings: clarify CS behavior for spi-cs-high and gpio descriptors")

it was clarified what the proper state for cs-gpios should be, even if the
flag is ignored. The driver code is doing the right thing since

766c6b63aa04 ("spi: fix client driver breakages when using GPIO descriptors")

The chip-select of the td028ttec1 panel is active-low, so we must omit spi-cs-high;
attribute (already removed by separate patch) and should now use GPIO_ACTIVE_LOW for
the client device description to be fully consistent.

Fixes: 766c6b63aa04 ("spi: fix client driver breakages when using GPIO descriptors")
CC: stable@vger.kernel.org
Signed-off-by: H. Nikolaus Schaller <hns@goldelico.com>
---
 arch/arm/boot/dts/omap3-gta04.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Tony Lindgren Dec. 30, 2020, 8:48 a.m. | #1
* H. Nikolaus Schaller <hns@goldelico.com> [201223 12:33]:
> With the arrival of
> 
> commit 2fee9583198eb9 ("spi: dt-bindings: clarify CS behavior for spi-cs-high and gpio descriptors")
> 
> it was clarified what the proper state for cs-gpios should be, even if the
> flag is ignored. The driver code is doing the right thing since
> 
> 766c6b63aa04 ("spi: fix client driver breakages when using GPIO descriptors")
> 
> The chip-select of the td028ttec1 panel is active-low, so we must omit spi-cs-high;
> attribute (already removed by separate patch) and should now use GPIO_ACTIVE_LOW for
> the client device description to be fully consistent.

Applying into fixes thanks.

Tony

Patch

diff --git a/arch/arm/boot/dts/omap3-gta04.dtsi b/arch/arm/boot/dts/omap3-gta04.dtsi
index 003202d129907b..7b8c18e6605e40 100644
--- a/arch/arm/boot/dts/omap3-gta04.dtsi
+++ b/arch/arm/boot/dts/omap3-gta04.dtsi
@@ -114,7 +114,7 @@  spi_lcd: spi_lcd {
 		gpio-sck = <&gpio1 12 GPIO_ACTIVE_HIGH>;
 		gpio-miso = <&gpio1 18 GPIO_ACTIVE_HIGH>;
 		gpio-mosi = <&gpio1 20 GPIO_ACTIVE_HIGH>;
-		cs-gpios = <&gpio1 19 GPIO_ACTIVE_HIGH>;
+		cs-gpios = <&gpio1 19 GPIO_ACTIVE_LOW>;
 		num-chipselects = <1>;
 
 		/* lcd panel */