diff mbox series

[RFC] remoteproc: qcom: wcnss: Adjust voltage requirements for Pronto v2

Message ID 20201226141100.90147-1-konrad.dybcio@somainline.org
State New
Headers show
Series [RFC] remoteproc: qcom: wcnss: Adjust voltage requirements for Pronto v2 | expand

Commit Message

Konrad Dybcio Dec. 26, 2020, 2:11 p.m. UTC
This is required for MSM8974 devices that cannot afford to push
the regulators further.

Signed-off-by: Konrad Dybcio <konrad.dybcio@somainline.org>
---
 drivers/remoteproc/qcom_wcnss.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Stephan Gerhold Jan. 4, 2021, 12:23 p.m. UTC | #1
Hi Konrad,

On Sat, Dec 26, 2020 at 03:11:00PM +0100, Konrad Dybcio wrote:
> This is required for MSM8974 devices that cannot afford to push

> the regulators further.

> 

> Signed-off-by: Konrad Dybcio <konrad.dybcio@somainline.org>

> ---

>  drivers/remoteproc/qcom_wcnss.c | 2 +-

>  1 file changed, 1 insertion(+), 1 deletion(-)

> 

> diff --git a/drivers/remoteproc/qcom_wcnss.c b/drivers/remoteproc/qcom_wcnss.c

> index e2573f79a137..71480be545e4 100644

> --- a/drivers/remoteproc/qcom_wcnss.c

> +++ b/drivers/remoteproc/qcom_wcnss.c

> @@ -124,7 +124,7 @@ static const struct wcnss_data pronto_v2_data = {

>  	.spare_offset = 0x1088,

>  

>  	.vregs = (struct wcnss_vreg_info[]) {

> -		{ "vddmx", 1287500, 1287500, 0 },

> +		{ "vddmx", 950000, 1150000, 0 },

>  		{ "vddcx", .super_turbo = true },

>  		{ "vddpx", 1800000, 1800000, 0 },

>  	},


Correct me if I'm wrong but with this change pronto_v2_data looks
exactly like pronto_v1_data (qcom,pronto-v1-pil).
Can you just change the compatible in qcom-msm8974.dtsi?

Also, if possible MSM8974 should be also moved to corner votes via rpmpd,
like in https://lore.kernel.org/linux-arm-msm/20200916104135.25085-1-stephan@gerhold.net/
Then the actual voltages don't matter anymore (all we need to do here is
to temporarily scale the power domain to maximum so WCNSS can boot up).

Thanks,
Stephan
diff mbox series

Patch

diff --git a/drivers/remoteproc/qcom_wcnss.c b/drivers/remoteproc/qcom_wcnss.c
index e2573f79a137..71480be545e4 100644
--- a/drivers/remoteproc/qcom_wcnss.c
+++ b/drivers/remoteproc/qcom_wcnss.c
@@ -124,7 +124,7 @@  static const struct wcnss_data pronto_v2_data = {
 	.spare_offset = 0x1088,
 
 	.vregs = (struct wcnss_vreg_info[]) {
-		{ "vddmx", 1287500, 1287500, 0 },
+		{ "vddmx", 950000, 1150000, 0 },
 		{ "vddcx", .super_turbo = true },
 		{ "vddpx", 1800000, 1800000, 0 },
 	},