| Message ID | 20201228163217.32520-3-post@lespocky.de |
|---|---|
| State | New |
| Headers | show |
| Series | leds: pwm: Make automatic labels work | expand |
On Mon, 28 Dec 2020 17:32:15 +0100 Alexander Dahl <post@lespocky.de> wrote: > > The node names for devices using the pwm-leds driver follow a certain > naming scheme (now). Parent node name is not enforced, but recommended > by DT project. > > DTC arch/arm/boot/dts/berlin2cd-google-chromecast.dt.yaml > CHECK arch/arm/boot/dts/berlin2cd-google-chromecast.dt.yaml > /home/alex/build/linux/arch/arm/boot/dts/berlin2cd-google-chromecast.dt.yaml: leds: 'red', 'white' do not match any of the regexes: '^led(-[0-9a-f]+)?$', 'pinctrl-[0-9]+' > From schema: /home/alex/src/linux/leds/Documentation/devicetree/bindings/leds/leds-pwm.yaml > > Signed-off-by: Alexander Dahl <post@lespocky.de> Thanks for the patch. I took this patch but sent out the PR late: https://www.spinics.net/lists/arm-kernel/msg862567.html I will send out PR earlier for 5.12 > --- > > Notes: > v8 -> v9: > * rebased on v5.11-rc1 > > v7 -> v8: > * rebased on recent pavel/for-next (post v5.10-rc1) > > v6 -> v7: > * split up patch (one per sub arch) > * added actual warnings to commit message > > arch/arm/boot/dts/berlin2cd-google-chromecast.dts | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/arch/arm/boot/dts/berlin2cd-google-chromecast.dts b/arch/arm/boot/dts/berlin2cd-google-chromecast.dts > index 56fa951bc86f..c1d91424e658 100644 > --- a/arch/arm/boot/dts/berlin2cd-google-chromecast.dts > +++ b/arch/arm/boot/dts/berlin2cd-google-chromecast.dts > @@ -34,19 +34,19 @@ > linux,usable-memory = <0x00000000 0x20000000>; /* 512 MB */ > }; > > - leds { > + led-controller { > compatible = "pwm-leds"; > pinctrl-0 = <&ledpwm_pmux>; > pinctrl-names = "default"; > > - white { > + led-1 { > label = "white"; > pwms = <&pwm 0 600000 0>; > max-brightness = <255>; > linux,default-trigger = "default-on"; > }; > > - red { > + led-2 { > label = "red"; > pwms = <&pwm 1 600000 0>; > max-brightness = <255>; > -- > 2.20.1 >
diff --git a/arch/arm/boot/dts/berlin2cd-google-chromecast.dts b/arch/arm/boot/dts/berlin2cd-google-chromecast.dts index 56fa951bc86f..c1d91424e658 100644 --- a/arch/arm/boot/dts/berlin2cd-google-chromecast.dts +++ b/arch/arm/boot/dts/berlin2cd-google-chromecast.dts @@ -34,19 +34,19 @@ linux,usable-memory = <0x00000000 0x20000000>; /* 512 MB */ }; - leds { + led-controller { compatible = "pwm-leds"; pinctrl-0 = <&ledpwm_pmux>; pinctrl-names = "default"; - white { + led-1 { label = "white"; pwms = <&pwm 0 600000 0>; max-brightness = <255>; linux,default-trigger = "default-on"; }; - red { + led-2 { label = "red"; pwms = <&pwm 1 600000 0>; max-brightness = <255>;
The node names for devices using the pwm-leds driver follow a certain naming scheme (now). Parent node name is not enforced, but recommended by DT project. DTC arch/arm/boot/dts/berlin2cd-google-chromecast.dt.yaml CHECK arch/arm/boot/dts/berlin2cd-google-chromecast.dt.yaml /home/alex/build/linux/arch/arm/boot/dts/berlin2cd-google-chromecast.dt.yaml: leds: 'red', 'white' do not match any of the regexes: '^led(-[0-9a-f]+)?$', 'pinctrl-[0-9]+' From schema: /home/alex/src/linux/leds/Documentation/devicetree/bindings/leds/leds-pwm.yaml Signed-off-by: Alexander Dahl <post@lespocky.de> --- Notes: v8 -> v9: * rebased on v5.11-rc1 v7 -> v8: * rebased on recent pavel/for-next (post v5.10-rc1) v6 -> v7: * split up patch (one per sub arch) * added actual warnings to commit message arch/arm/boot/dts/berlin2cd-google-chromecast.dts | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)