| Message ID | 20201228082433.16431-1-pkshih@realtek.com |
|---|---|
| State | New |
| Headers | show |
| Series | rtw88: reduce the log level for failure of tx report | expand |
Ping-Ke Shih <pkshih@realtek.com> wrote: > From: Chin-Yen Lee <timlee@realtek.com> > > Sometimes driver does not get tx report from firmware because wifi > environment is too noisy to get ack from AP about a TX frame, > or firmware is too busy to report driver in a estimated time. > But the condition will not affect wifi function or throughput. > So we reduce the log level to rtw_debug instead of scary backtrace. > > Signed-off-by: Chin-Yen Lee <timlee@realtek.com> > Signed-off-by: Ping-Ke Shih <pkshih@realtek.com> Patch applied to wireless-drivers-next.git, thanks. ac9533d2a637 rtw88: reduce the log level for failure of tx report -- https://patchwork.kernel.org/project/linux-wireless/patch/20201228082433.16431-1-pkshih@realtek.com/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
diff --git a/drivers/net/wireless/realtek/rtw88/tx.c b/drivers/net/wireless/realtek/rtw88/tx.c index ca8072177ae3..18ec0088bf41 100644 --- a/drivers/net/wireless/realtek/rtw88/tx.c +++ b/drivers/net/wireless/realtek/rtw88/tx.c @@ -158,7 +158,7 @@ void rtw_tx_report_purge_timer(struct timer_list *t) if (skb_queue_len(&tx_report->queue) == 0) return; - WARN(1, "purge skb(s) not reported by firmware\n"); + rtw_dbg(rtwdev, RTW_DBG_TX, "purge skb(s) not reported by firmware\n"); spin_lock_irqsave(&tx_report->q_lock, flags); skb_queue_purge(&tx_report->queue);