pinctrl: ralink: rt2880: fix '-Wmissing-prototypes' in init function

Message ID 20201228064727.30098-1-sergio.paracuellos@gmail.com
State New
Headers show
Series
  • pinctrl: ralink: rt2880: fix '-Wmissing-prototypes' in init function
Related show

Commit Message

Sergio Paracuellos Dec. 28, 2020, 6:47 a.m.
Kernel test robot reported the following warning:
'warning: no previous prototype for 'rt2880_pinmux_init''.
This function is the entry point for the platform driver and
it is private to this driver. Hence declare it 'static' which is
the correct thing to do fixing also this warning.

Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Sergio Paracuellos <sergio.paracuellos@gmail.com>
---
Hi Linus, 

Just a note to let you know that this patch is rebased on the top of this
series which are pending to be applied:
http://driverdev.linuxdriverproject.org/pipermail/driverdev-devel/2020-December/149353.html

Thanks in advance for your time!

Best regards,
    Sergio Paracuellos

 drivers/pinctrl/ralink/pinctrl-rt2880.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Linus Walleij Jan. 4, 2021, 2:40 p.m. | #1
On Mon, Dec 28, 2020 at 7:47 AM Sergio Paracuellos
<sergio.paracuellos@gmail.com> wrote:

> Kernel test robot reported the following warning:

> 'warning: no previous prototype for 'rt2880_pinmux_init''.

> This function is the entry point for the platform driver and

> it is private to this driver. Hence declare it 'static' which is

> the correct thing to do fixing also this warning.

>

> Reported-by: kernel test robot <lkp@intel.com>

> Signed-off-by: Sergio Paracuellos <sergio.paracuellos@gmail.com>


Patch applied.

Yours,
Linus Walleij

Patch

diff --git a/drivers/pinctrl/ralink/pinctrl-rt2880.c b/drivers/pinctrl/ralink/pinctrl-rt2880.c
index 983da62ff3be..1f8e8d5b71fd 100644
--- a/drivers/pinctrl/ralink/pinctrl-rt2880.c
+++ b/drivers/pinctrl/ralink/pinctrl-rt2880.c
@@ -361,7 +361,7 @@  static struct platform_driver rt2880_pinmux_driver = {
 	},
 };
 
-int __init rt2880_pinmux_init(void)
+static int __init rt2880_pinmux_init(void)
 {
 	return platform_driver_register(&rt2880_pinmux_driver);
 }