regulator: as3722: .name field initialized twice differently

Message ID 1408100984-11757-1-git-send-email-peter.griffin@linaro.org
State New
Headers show

Commit Message

Peter Griffin Aug. 15, 2014, 11:09 a.m.
Regulator AS3722_REGULATOR_ID_LDO3 and AS3722_REGULATOR_ID_LDO4
have there .name field initialised twice with different values.

Looking at the code the second entry should have been .sname
which is what this patch corrects.

Signed-off-by: Peter Griffin <peter.griffin@linaro.org>
---
 drivers/regulator/as3722-regulator.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Mark Brown Aug. 15, 2014, 11:41 a.m. | #1
On Fri, Aug 15, 2014 at 12:09:44PM +0100, Peter Griffin wrote:
> Regulator AS3722_REGULATOR_ID_LDO3 and AS3722_REGULATOR_ID_LDO4
> have there .name field initialised twice with different values.
> 
> Looking at the code the second entry should have been .sname
> which is what this patch corrects.

This change appears to already be present in current code - please
submit against current code, or Linus' tree for bug fixes.

Patch

diff --git a/drivers/regulator/as3722-regulator.c b/drivers/regulator/as3722-regulator.c
index ad9e0c9..b68f05f 100644
--- a/drivers/regulator/as3722-regulator.c
+++ b/drivers/regulator/as3722-regulator.c
@@ -219,7 +219,7 @@  static const struct as3722_register_mapping as3722_reg_lookup[] = {
 	{
 		.regulator_id = AS3722_REGULATOR_ID_LDO3,
 		.name = "as3722-ldo3",
-		.name = "vin-ldo3-4",
+		.sname = "vin-ldo3-4",
 		.vsel_reg = AS3722_LDO3_VOLTAGE_REG,
 		.vsel_mask = AS3722_LDO3_VSEL_MASK,
 		.enable_reg = AS3722_LDOCONTROL0_REG,
@@ -231,7 +231,7 @@  static const struct as3722_register_mapping as3722_reg_lookup[] = {
 	{
 		.regulator_id = AS3722_REGULATOR_ID_LDO4,
 		.name = "as3722-ldo4",
-		.name = "vin-ldo3-4",
+		.sname = "vin-ldo3-4",
 		.vsel_reg = AS3722_LDO4_VOLTAGE_REG,
 		.vsel_mask = AS3722_LDO_VSEL_MASK,
 		.enable_reg = AS3722_LDOCONTROL0_REG,