| Message ID | 20201231153842.25782-1-prabhakar.mahadev-lad.rj@bp.renesas.com |
|---|---|
| State | Superseded |
| Headers | show |
| Series | gpio: Kconfig: Update help description for GPIO_RCAR | expand |
Hi Prabhakar, > -----Original Message----- > From: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com> > Sent: 31 December 2020 15:39 > To: Linus Walleij <linus.walleij@linaro.org>; Bartosz Golaszewski > <bgolaszewski@baylibre.com>; Geert Uytterhoeven <geert+renesas@glider.be> > Cc: linux-gpio@vger.kernel.org; linux-kernel@vger.kernel.org; linux- > renesas-soc@vger.kernel.org; Prabhakar <prabhakar.csengg@gmail.com>; > Prabhakar Mahadev Lad <prabhakar.mahadev-lad.rj@bp.renesas.com> > Subject: [PATCH] gpio: Kconfig: Update help description for GPIO_RCAR > > The gpio-rcar driver supports R-Car Gen{1,2,3} and RZ/G{1,2} SoC's, update > the description to reflect this. Not sure we need to make this generic by dropping {1,2,3}/{1,2} and use R-Car and RZ/G SoC's instead ??? Regards, Biju > > Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com> > --- > drivers/gpio/Kconfig | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpio/Kconfig b/drivers/gpio/Kconfig index > c70f46e80a3b..47e545d71df1 100644 > --- a/drivers/gpio/Kconfig > +++ b/drivers/gpio/Kconfig > @@ -486,11 +486,12 @@ config GPIO_PXA > Say yes here to support the PXA GPIO device > > config GPIO_RCAR > - tristate "Renesas R-Car GPIO" > + tristate "Renesas R-Car Gen{1,2,3} and RZ/G{1,2} GPIO support" > depends on ARCH_RENESAS || COMPILE_TEST > select GPIOLIB_IRQCHIP > help > - Say yes here to support GPIO on Renesas R-Car SoCs. > + Say yes here to support GPIO on Renesas R-Car Gen{1,2,3} and > + RZ/G{1,2} SoCs. > > config GPIO_RDA > bool "RDA Micro GPIO controller support" > -- > 2.17.1
On Fri, Jan 1, 2021 at 6:07 PM Biju Das <biju.das.jz@bp.renesas.com> wrote: > > Hi Prabhakar, > > > -----Original Message----- > > From: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com> > > Sent: 31 December 2020 15:39 > > To: Linus Walleij <linus.walleij@linaro.org>; Bartosz Golaszewski > > <bgolaszewski@baylibre.com>; Geert Uytterhoeven <geert+renesas@glider.be> > > Cc: linux-gpio@vger.kernel.org; linux-kernel@vger.kernel.org; linux- > > renesas-soc@vger.kernel.org; Prabhakar <prabhakar.csengg@gmail.com>; > > Prabhakar Mahadev Lad <prabhakar.mahadev-lad.rj@bp.renesas.com> > > Subject: [PATCH] gpio: Kconfig: Update help description for GPIO_RCAR > > > > The gpio-rcar driver supports R-Car Gen{1,2,3} and RZ/G{1,2} SoC's, update > > the description to reflect this. > > Not sure we need to make this generic by dropping {1,2,3}/{1,2} and use R-Car and RZ/G SoC's instead ??? > This looks better IMO - if Geert is OK with that, then let's change it. Bart > Regards, > Biju > > > > > Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com> > > --- > > drivers/gpio/Kconfig | 5 +++-- > > 1 file changed, 3 insertions(+), 2 deletions(-) > > > > diff --git a/drivers/gpio/Kconfig b/drivers/gpio/Kconfig index > > c70f46e80a3b..47e545d71df1 100644 > > --- a/drivers/gpio/Kconfig > > +++ b/drivers/gpio/Kconfig > > @@ -486,11 +486,12 @@ config GPIO_PXA > > Say yes here to support the PXA GPIO device > > > > config GPIO_RCAR > > - tristate "Renesas R-Car GPIO" > > + tristate "Renesas R-Car Gen{1,2,3} and RZ/G{1,2} GPIO support" > > depends on ARCH_RENESAS || COMPILE_TEST > > select GPIOLIB_IRQCHIP > > help > > - Say yes here to support GPIO on Renesas R-Car SoCs. > > + Say yes here to support GPIO on Renesas R-Car Gen{1,2,3} and > > + RZ/G{1,2} SoCs. > > > > config GPIO_RDA > > bool "RDA Micro GPIO controller support" > > -- > > 2.17.1 >
Hi Bartosz et al, On Sun, Jan 3, 2021 at 4:29 PM Bartosz Golaszewski <bgolaszewski@baylibre.com> wrote: > On Fri, Jan 1, 2021 at 6:07 PM Biju Das <biju.das.jz@bp.renesas.com> wrote: > > > -----Original Message----- > > > From: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com> > > > Sent: 31 December 2020 15:39 > > > To: Linus Walleij <linus.walleij@linaro.org>; Bartosz Golaszewski > > > <bgolaszewski@baylibre.com>; Geert Uytterhoeven <geert+renesas@glider.be> > > > Cc: linux-gpio@vger.kernel.org; linux-kernel@vger.kernel.org; linux- > > > renesas-soc@vger.kernel.org; Prabhakar <prabhakar.csengg@gmail.com>; > > > Prabhakar Mahadev Lad <prabhakar.mahadev-lad.rj@bp.renesas.com> > > > Subject: [PATCH] gpio: Kconfig: Update help description for GPIO_RCAR > > > > > > The gpio-rcar driver supports R-Car Gen{1,2,3} and RZ/G{1,2} SoC's, update > > > the description to reflect this. > > > > Not sure we need to make this generic by dropping {1,2,3}/{1,2} and use R-Car and RZ/G SoC's instead ??? > > > > This looks better IMO - if Geert is OK with that, then let's change it. "R-Car and RZ/G" sounds better to me, as it is present on all known R-Car and RZ/G SoCs. We can change the help text if that ever changes. > > > --- a/drivers/gpio/Kconfig > > > +++ b/drivers/gpio/Kconfig > > > @@ -486,11 +486,12 @@ config GPIO_PXA > > > Say yes here to support the PXA GPIO device > > > > > > config GPIO_RCAR > > > - tristate "Renesas R-Car GPIO" > > > + tristate "Renesas R-Car Gen{1,2,3} and RZ/G{1,2} GPIO support" > > > depends on ARCH_RENESAS || COMPILE_TEST > > > select GPIOLIB_IRQCHIP > > > help > > > - Say yes here to support GPIO on Renesas R-Car SoCs. > > > + Say yes here to support GPIO on Renesas R-Car Gen{1,2,3} and > > > + RZ/G{1,2} SoCs. > > > > > > config GPIO_RDA > > > bool "RDA Micro GPIO controller support" Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
diff --git a/drivers/gpio/Kconfig b/drivers/gpio/Kconfig index c70f46e80a3b..47e545d71df1 100644 --- a/drivers/gpio/Kconfig +++ b/drivers/gpio/Kconfig @@ -486,11 +486,12 @@ config GPIO_PXA Say yes here to support the PXA GPIO device config GPIO_RCAR - tristate "Renesas R-Car GPIO" + tristate "Renesas R-Car Gen{1,2,3} and RZ/G{1,2} GPIO support" depends on ARCH_RENESAS || COMPILE_TEST select GPIOLIB_IRQCHIP help - Say yes here to support GPIO on Renesas R-Car SoCs. + Say yes here to support GPIO on Renesas R-Car Gen{1,2,3} and + RZ/G{1,2} SoCs. config GPIO_RDA bool "RDA Micro GPIO controller support"
The gpio-rcar driver supports R-Car Gen{1,2,3} and RZ/G{1,2} SoC's, update the description to reflect this. Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com> --- drivers/gpio/Kconfig | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)