diff mbox series

[3/7] can: kvaser_pciefd: select CONFIG_CRC32

Message ID 20210103213645.1994783-3-arnd@kernel.org
State New
Headers show
Series [1/7] qed: select CONFIG_CRC32 | expand

Commit Message

Arnd Bergmann Jan. 3, 2021, 9:36 p.m. UTC 
From: Arnd Bergmann <arnd@arndb.de>


Without crc32, this driver fails to link:

arm-linux-gnueabi-ld: drivers/net/can/kvaser_pciefd.o: in function `kvaser_pciefd_probe':
kvaser_pciefd.c:(.text+0x2b0): undefined reference to `crc32_be'

Fixes: 26ad340e582d ("can: kvaser_pciefd: Add driver for Kvaser PCIEcan devices")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>

---
 drivers/net/can/Kconfig | 1 +
 1 file changed, 1 insertion(+)

-- 
2.29.2

Comments

Marc Kleine-Budde Jan. 4, 2021, 8:43 a.m. UTC | #1 
On 1/3/21 10:36 PM, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>

> 

> Without crc32, this driver fails to link:

> 

> arm-linux-gnueabi-ld: drivers/net/can/kvaser_pciefd.o: in function `kvaser_pciefd_probe':

> kvaser_pciefd.c:(.text+0x2b0): undefined reference to `crc32_be'

> 

> Fixes: 26ad340e582d ("can: kvaser_pciefd: Add driver for Kvaser PCIEcan devices")

> Signed-off-by: Arnd Bergmann <arnd@arndb.de>


Acked-by: Marc Kleine-Budde <mkl@pengutronix.de>


regrards,
Marc

-- 
Pengutronix e.K.                 | Marc Kleine-Budde           |
Embedded Linux                   | https://www.pengutronix.de  |
Vertretung West/Dortmund         | Phone: +49-231-2826-924     |
Amtsgericht Hildesheim, HRA 2686 | Fax:   +49-5121-206917-5555 |
diff mbox series

Patch

diff --git a/drivers/net/can/Kconfig b/drivers/net/can/Kconfig
index 424970939fd4..1c28eade6bec 100644
--- a/drivers/net/can/Kconfig
+++ b/drivers/net/can/Kconfig
@@ -123,6 +123,7 @@  config CAN_JANZ_ICAN3
 config CAN_KVASER_PCIEFD
 	depends on PCI
 	tristate "Kvaser PCIe FD cards"
+	select CRC32
 	  help
 	  This is a driver for the Kvaser PCI Express CAN FD family.