diff mbox series

rpmsg: glink: add a header file

Message ID 20210105235528.32538-1-elder@linaro.org
State New
Headers show
Series rpmsg: glink: add a header file | expand

Commit Message

Alex Elder Jan. 5, 2021, 11:55 p.m. UTC 
With an x86_64 architecture W=1 build, qcom_glink_ssr_notify() is
reported as having no previous prototype.  The prototype is found in
"qcom_glink.h", so we just need "qcom_glink_ssr.c" to include that
file.

Signed-off-by: Alex Elder <elder@linaro.org>

---
 drivers/rpmsg/qcom_glink_ssr.c | 1 +
 1 file changed, 1 insertion(+)

-- 
2.20.1

Comments

kernel test robot Jan. 6, 2021, 2:42 a.m. UTC | #1 
Hi Alex,

I love your patch! Yet something to improve:

[auto build test ERROR on linus/master]
[also build test ERROR on v5.11-rc2 next-20210104]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Alex-Elder/rpmsg-glink-add-a-header-file/20210106-080024
base:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git e71ba9452f0b5b2e8dc8aa5445198cd9214a6a62
config: x86_64-randconfig-s021-20210106 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-15) 9.3.0
reproduce:
        # apt-get install sparse
        # sparse version: v0.6.3-208-g46a52ca4-dirty
        # https://github.com/0day-ci/linux/commit/333b19e6f90b89d18b94be972c0823959373dad8
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Alex-Elder/rpmsg-glink-add-a-header-file/20210106-080024
        git checkout 333b19e6f90b89d18b94be972c0823959373dad8
        # save the attached .config to linux build tree
        make W=1 C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' ARCH=x86_64 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

>> drivers/rpmsg/qcom_glink_ssr.c:65:6: error: redefinition of 'qcom_glink_ssr_notify'

      65 | void qcom_glink_ssr_notify(const char *ssr_name)
         |      ^~~~~~~~~~~~~~~~~~~~~
   In file included from drivers/rpmsg/qcom_glink_ssr.c:11:
   include/linux/rpmsg/qcom_glink.h:27:20: note: previous definition of 'qcom_glink_ssr_notify' was here
      27 | static inline void qcom_glink_ssr_notify(const char *ssr_name) {}
         |                    ^~~~~~~~~~~~~~~~~~~~~


vim +/qcom_glink_ssr_notify +65 drivers/rpmsg/qcom_glink_ssr.c

5d1f2e3c8090c07 drivers/soc/qcom/glink_ssr.c Bjorn Andersson 2020-04-22  60  
5d1f2e3c8090c07 drivers/soc/qcom/glink_ssr.c Bjorn Andersson 2020-04-22  61  /**
5d1f2e3c8090c07 drivers/soc/qcom/glink_ssr.c Bjorn Andersson 2020-04-22  62   * qcom_glink_ssr_notify() - notify GLINK SSR about stopped remoteproc
5d1f2e3c8090c07 drivers/soc/qcom/glink_ssr.c Bjorn Andersson 2020-04-22  63   * @ssr_name:	name of the remoteproc that has been stopped
5d1f2e3c8090c07 drivers/soc/qcom/glink_ssr.c Bjorn Andersson 2020-04-22  64   */
5d1f2e3c8090c07 drivers/soc/qcom/glink_ssr.c Bjorn Andersson 2020-04-22 @65  void qcom_glink_ssr_notify(const char *ssr_name)
5d1f2e3c8090c07 drivers/soc/qcom/glink_ssr.c Bjorn Andersson 2020-04-22  66  {
5d1f2e3c8090c07 drivers/soc/qcom/glink_ssr.c Bjorn Andersson 2020-04-22  67  	blocking_notifier_call_chain(&ssr_notifiers, 0, (void *)ssr_name);
5d1f2e3c8090c07 drivers/soc/qcom/glink_ssr.c Bjorn Andersson 2020-04-22  68  }
5d1f2e3c8090c07 drivers/soc/qcom/glink_ssr.c Bjorn Andersson 2020-04-22  69  EXPORT_SYMBOL_GPL(qcom_glink_ssr_notify);
5d1f2e3c8090c07 drivers/soc/qcom/glink_ssr.c Bjorn Andersson 2020-04-22  70  

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
Alex Elder Jan. 6, 2021, 4:19 a.m. UTC | #2 
On 1/5/21 10:01 PM, Bjorn Andersson wrote:
> On Tue 05 Jan 20:42 CST 2021, kernel test robot wrote:

> 

>> Hi Alex,

>>

>> I love your patch! Yet something to improve:

>>

> 

> Alex, this turns out to be an existing problem. Please have a look at my

> proposal for a fix here:

> 

> https://lore.kernel.org/linux-remoteproc/20210106035905.4153692-1-bjorn.andersson@linaro.org/T/#u

> 

> If you like it I can merge it and then apply this patch on top.


Go ahead and merge your patch.  If you are sure mine will
work afterward (I think it will) I would be happy to have
you accept that as well.  Thanks.

					-Alex

> 

> Thanks,

> Bjorn

> 

>> [auto build test ERROR on linus/master]

>> [also build test ERROR on v5.11-rc2 next-20210104]

>> [If your patch is applied to the wrong git tree, kindly drop us a note.

>> And when submitting patch, we suggest to use '--base' as documented in

>> https://git-scm.com/docs/git-format-patch]

>>

>> url:    https://github.com/0day-ci/linux/commits/Alex-Elder/rpmsg-glink-add-a-header-file/20210106-080024

>> base:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git e71ba9452f0b5b2e8dc8aa5445198cd9214a6a62

>> config: x86_64-randconfig-s021-20210106 (attached as .config)

>> compiler: gcc-9 (Debian 9.3.0-15) 9.3.0

>> reproduce:

>>          # apt-get install sparse

>>          # sparse version: v0.6.3-208-g46a52ca4-dirty

>>          # https://github.com/0day-ci/linux/commit/333b19e6f90b89d18b94be972c0823959373dad8

>>          git remote add linux-review https://github.com/0day-ci/linux

>>          git fetch --no-tags linux-review Alex-Elder/rpmsg-glink-add-a-header-file/20210106-080024

>>          git checkout 333b19e6f90b89d18b94be972c0823959373dad8

>>          # save the attached .config to linux build tree

>>          make W=1 C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' ARCH=x86_64

>>

>> If you fix the issue, kindly add following tag as appropriate

>> Reported-by: kernel test robot <lkp@intel.com>

>>

>> All errors (new ones prefixed by >>):

>>

>>>> drivers/rpmsg/qcom_glink_ssr.c:65:6: error: redefinition of 'qcom_glink_ssr_notify'

>>        65 | void qcom_glink_ssr_notify(const char *ssr_name)

>>           |      ^~~~~~~~~~~~~~~~~~~~~

>>     In file included from drivers/rpmsg/qcom_glink_ssr.c:11:

>>     include/linux/rpmsg/qcom_glink.h:27:20: note: previous definition of 'qcom_glink_ssr_notify' was here

>>        27 | static inline void qcom_glink_ssr_notify(const char *ssr_name) {}

>>           |                    ^~~~~~~~~~~~~~~~~~~~~

>>

>>

>> vim +/qcom_glink_ssr_notify +65 drivers/rpmsg/qcom_glink_ssr.c

>>

>> 5d1f2e3c8090c07 drivers/soc/qcom/glink_ssr.c Bjorn Andersson 2020-04-22  60

>> 5d1f2e3c8090c07 drivers/soc/qcom/glink_ssr.c Bjorn Andersson 2020-04-22  61  /**

>> 5d1f2e3c8090c07 drivers/soc/qcom/glink_ssr.c Bjorn Andersson 2020-04-22  62   * qcom_glink_ssr_notify() - notify GLINK SSR about stopped remoteproc

>> 5d1f2e3c8090c07 drivers/soc/qcom/glink_ssr.c Bjorn Andersson 2020-04-22  63   * @ssr_name:	name of the remoteproc that has been stopped

>> 5d1f2e3c8090c07 drivers/soc/qcom/glink_ssr.c Bjorn Andersson 2020-04-22  64   */

>> 5d1f2e3c8090c07 drivers/soc/qcom/glink_ssr.c Bjorn Andersson 2020-04-22 @65  void qcom_glink_ssr_notify(const char *ssr_name)

>> 5d1f2e3c8090c07 drivers/soc/qcom/glink_ssr.c Bjorn Andersson 2020-04-22  66  {

>> 5d1f2e3c8090c07 drivers/soc/qcom/glink_ssr.c Bjorn Andersson 2020-04-22  67  	blocking_notifier_call_chain(&ssr_notifiers, 0, (void *)ssr_name);

>> 5d1f2e3c8090c07 drivers/soc/qcom/glink_ssr.c Bjorn Andersson 2020-04-22  68  }

>> 5d1f2e3c8090c07 drivers/soc/qcom/glink_ssr.c Bjorn Andersson 2020-04-22  69  EXPORT_SYMBOL_GPL(qcom_glink_ssr_notify);

>> 5d1f2e3c8090c07 drivers/soc/qcom/glink_ssr.c Bjorn Andersson 2020-04-22  70

>>

>> ---

>> 0-DAY CI Kernel Test Service, Intel Corporation

>> https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

> 

>
Bjorn Andersson Jan. 6, 2021, 4:23 a.m. UTC | #3 
On Tue 05 Jan 22:19 CST 2021, Alex Elder wrote:

> On 1/5/21 10:01 PM, Bjorn Andersson wrote:

> > On Tue 05 Jan 20:42 CST 2021, kernel test robot wrote:

> > 

> > > Hi Alex,

> > > 

> > > I love your patch! Yet something to improve:

> > > 

> > 

> > Alex, this turns out to be an existing problem. Please have a look at my

> > proposal for a fix here:

> > 

> > https://lore.kernel.org/linux-remoteproc/20210106035905.4153692-1-bjorn.andersson@linaro.org/T/#u

> > 

> > If you like it I can merge it and then apply this patch on top.

> 

> Go ahead and merge your patch.  If you are sure mine will

> work afterward (I think it will) I would be happy to have

> you accept that as well.  Thanks.

> 


Thank you Alex. I've merged the pair (and that other patch of yours).

And thanks KTR for reporting this.

Regards,
Bjorn

> 					-Alex

> 

> > 

> > Thanks,

> > Bjorn

> > 

> > > [auto build test ERROR on linus/master]

> > > [also build test ERROR on v5.11-rc2 next-20210104]

> > > [If your patch is applied to the wrong git tree, kindly drop us a note.

> > > And when submitting patch, we suggest to use '--base' as documented in

> > > https://git-scm.com/docs/git-format-patch]

> > > 

> > > url:    https://github.com/0day-ci/linux/commits/Alex-Elder/rpmsg-glink-add-a-header-file/20210106-080024

> > > base:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git e71ba9452f0b5b2e8dc8aa5445198cd9214a6a62

> > > config: x86_64-randconfig-s021-20210106 (attached as .config)

> > > compiler: gcc-9 (Debian 9.3.0-15) 9.3.0

> > > reproduce:

> > >          # apt-get install sparse

> > >          # sparse version: v0.6.3-208-g46a52ca4-dirty

> > >          # https://github.com/0day-ci/linux/commit/333b19e6f90b89d18b94be972c0823959373dad8

> > >          git remote add linux-review https://github.com/0day-ci/linux

> > >          git fetch --no-tags linux-review Alex-Elder/rpmsg-glink-add-a-header-file/20210106-080024

> > >          git checkout 333b19e6f90b89d18b94be972c0823959373dad8

> > >          # save the attached .config to linux build tree

> > >          make W=1 C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' ARCH=x86_64

> > > 

> > > If you fix the issue, kindly add following tag as appropriate

> > > Reported-by: kernel test robot <lkp@intel.com>

> > > 

> > > All errors (new ones prefixed by >>):

> > > 

> > > > > drivers/rpmsg/qcom_glink_ssr.c:65:6: error: redefinition of 'qcom_glink_ssr_notify'

> > >        65 | void qcom_glink_ssr_notify(const char *ssr_name)

> > >           |      ^~~~~~~~~~~~~~~~~~~~~

> > >     In file included from drivers/rpmsg/qcom_glink_ssr.c:11:

> > >     include/linux/rpmsg/qcom_glink.h:27:20: note: previous definition of 'qcom_glink_ssr_notify' was here

> > >        27 | static inline void qcom_glink_ssr_notify(const char *ssr_name) {}

> > >           |                    ^~~~~~~~~~~~~~~~~~~~~

> > > 

> > > 

> > > vim +/qcom_glink_ssr_notify +65 drivers/rpmsg/qcom_glink_ssr.c

> > > 

> > > 5d1f2e3c8090c07 drivers/soc/qcom/glink_ssr.c Bjorn Andersson 2020-04-22  60

> > > 5d1f2e3c8090c07 drivers/soc/qcom/glink_ssr.c Bjorn Andersson 2020-04-22  61  /**

> > > 5d1f2e3c8090c07 drivers/soc/qcom/glink_ssr.c Bjorn Andersson 2020-04-22  62   * qcom_glink_ssr_notify() - notify GLINK SSR about stopped remoteproc

> > > 5d1f2e3c8090c07 drivers/soc/qcom/glink_ssr.c Bjorn Andersson 2020-04-22  63   * @ssr_name:	name of the remoteproc that has been stopped

> > > 5d1f2e3c8090c07 drivers/soc/qcom/glink_ssr.c Bjorn Andersson 2020-04-22  64   */

> > > 5d1f2e3c8090c07 drivers/soc/qcom/glink_ssr.c Bjorn Andersson 2020-04-22 @65  void qcom_glink_ssr_notify(const char *ssr_name)

> > > 5d1f2e3c8090c07 drivers/soc/qcom/glink_ssr.c Bjorn Andersson 2020-04-22  66  {

> > > 5d1f2e3c8090c07 drivers/soc/qcom/glink_ssr.c Bjorn Andersson 2020-04-22  67  	blocking_notifier_call_chain(&ssr_notifiers, 0, (void *)ssr_name);

> > > 5d1f2e3c8090c07 drivers/soc/qcom/glink_ssr.c Bjorn Andersson 2020-04-22  68  }

> > > 5d1f2e3c8090c07 drivers/soc/qcom/glink_ssr.c Bjorn Andersson 2020-04-22  69  EXPORT_SYMBOL_GPL(qcom_glink_ssr_notify);

> > > 5d1f2e3c8090c07 drivers/soc/qcom/glink_ssr.c Bjorn Andersson 2020-04-22  70

> > > 

> > > ---

> > > 0-DAY CI Kernel Test Service, Intel Corporation

> > > https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

> > 

> > 

>
kernel test robot Jan. 6, 2021, 7:27 a.m. UTC | #4 
Hi Alex,

I love your patch! Yet something to improve:

[auto build test ERROR on linus/master]
[also build test ERROR on v5.11-rc2 next-20210104]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Alex-Elder/rpmsg-glink-add-a-header-file/20210106-080024
base:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git e71ba9452f0b5b2e8dc8aa5445198cd9214a6a62
config: x86_64-randconfig-a015-20210106 (attached as .config)
compiler: clang version 12.0.0 (https://github.com/llvm/llvm-project 5c951623bc8965fa1e89660f2f5f4a2944e4981a)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # install x86_64 cross compiling tool for clang build
        # apt-get install binutils-x86-64-linux-gnu
        # https://github.com/0day-ci/linux/commit/333b19e6f90b89d18b94be972c0823959373dad8
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Alex-Elder/rpmsg-glink-add-a-header-file/20210106-080024
        git checkout 333b19e6f90b89d18b94be972c0823959373dad8
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=x86_64 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

>> drivers/rpmsg/qcom_glink_ssr.c:65:6: error: redefinition of 'qcom_glink_ssr_notify'

   void qcom_glink_ssr_notify(const char *ssr_name)
        ^
   include/linux/rpmsg/qcom_glink.h:27:20: note: previous definition is here
   static inline void qcom_glink_ssr_notify(const char *ssr_name) {}
                      ^
   1 error generated.


vim +/qcom_glink_ssr_notify +65 drivers/rpmsg/qcom_glink_ssr.c

5d1f2e3c8090c07 drivers/soc/qcom/glink_ssr.c Bjorn Andersson 2020-04-22  60  
5d1f2e3c8090c07 drivers/soc/qcom/glink_ssr.c Bjorn Andersson 2020-04-22  61  /**
5d1f2e3c8090c07 drivers/soc/qcom/glink_ssr.c Bjorn Andersson 2020-04-22  62   * qcom_glink_ssr_notify() - notify GLINK SSR about stopped remoteproc
5d1f2e3c8090c07 drivers/soc/qcom/glink_ssr.c Bjorn Andersson 2020-04-22  63   * @ssr_name:	name of the remoteproc that has been stopped
5d1f2e3c8090c07 drivers/soc/qcom/glink_ssr.c Bjorn Andersson 2020-04-22  64   */
5d1f2e3c8090c07 drivers/soc/qcom/glink_ssr.c Bjorn Andersson 2020-04-22 @65  void qcom_glink_ssr_notify(const char *ssr_name)
5d1f2e3c8090c07 drivers/soc/qcom/glink_ssr.c Bjorn Andersson 2020-04-22  66  {
5d1f2e3c8090c07 drivers/soc/qcom/glink_ssr.c Bjorn Andersson 2020-04-22  67  	blocking_notifier_call_chain(&ssr_notifiers, 0, (void *)ssr_name);
5d1f2e3c8090c07 drivers/soc/qcom/glink_ssr.c Bjorn Andersson 2020-04-22  68  }
5d1f2e3c8090c07 drivers/soc/qcom/glink_ssr.c Bjorn Andersson 2020-04-22  69  EXPORT_SYMBOL_GPL(qcom_glink_ssr_notify);
5d1f2e3c8090c07 drivers/soc/qcom/glink_ssr.c Bjorn Andersson 2020-04-22  70  

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
patchwork-bot+linux-arm-msm@kernel.org March 1, 2021, 7:59 p.m. UTC | #5 
Hello:

This patch was applied to qcom/linux.git (refs/heads/for-next):

On Tue,  5 Jan 2021 17:55:28 -0600 you wrote:
> With an x86_64 architecture W=1 build, qcom_glink_ssr_notify() is

> reported as having no previous prototype.  The prototype is found in

> "qcom_glink.h", so we just need "qcom_glink_ssr.c" to include that

> file.

> 

> Signed-off-by: Alex Elder <elder@linaro.org>

> 

> [...]


Here is the summary with links:
  - rpmsg: glink: add a header file
    https://git.kernel.org/qcom/c/3e35772bc1e4

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
diff mbox series

Patch

diff --git a/drivers/rpmsg/qcom_glink_ssr.c b/drivers/rpmsg/qcom_glink_ssr.c
index dcd1ce6169747..4da6c7d985568 100644
--- a/drivers/rpmsg/qcom_glink_ssr.c
+++ b/drivers/rpmsg/qcom_glink_ssr.c
@@ -8,6 +8,7 @@ 
 #include <linux/module.h>
 #include <linux/notifier.h>
 #include <linux/rpmsg.h>
+#include <linux/rpmsg/qcom_glink.h>
 #include <linux/remoteproc/qcom_rproc.h>
 
 /**