diff mbox series

[net,v2] macvlan: remove redundant null check on data

Message ID 1609828294-6284-1-git-send-email-wangyunjian@huawei.com
State New
Headers show
Series [net,v2] macvlan: remove redundant null check on data | expand

Commit Message

wangyunjian Jan. 5, 2021, 6:31 a.m. UTC 
From: Yunjian Wang <wangyunjian@huawei.com>

Because macvlan_common_newlink() and macvlan_changelink() already
checked NULL data parameter, so the additional check is unnecessary,
just remove it.

Fixes: 79cf79abce71 ("macvlan: add source mode")
Signed-off-by: Yunjian Wang <wangyunjian@huawei.com>
---
v2:
  * change code styles and commit log suggested by Jakub Kicinski
---
 drivers/net/macvlan.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

David Miller Jan. 6, 2021, 12:53 a.m. UTC | #1 
From: wangyunjian <wangyunjian@huawei.com>

Date: Tue, 5 Jan 2021 14:31:34 +0800

> From: Yunjian Wang <wangyunjian@huawei.com>

> 

> Because macvlan_common_newlink() and macvlan_changelink() already

> checked NULL data parameter, so the additional check is unnecessary,

> just remove it.

> 

> Fixes: 79cf79abce71 ("macvlan: add source mode")

> Signed-off-by: Yunjian Wang <wangyunjian@huawei.com>

> ---

> v2:

>   * change code styles and commit log suggested by Jakub Kicinski

> ---


Applied to net-next, thanks.
diff mbox series

Patch

diff --git a/drivers/net/macvlan.c b/drivers/net/macvlan.c
index fb51329f8964..9a9a5cf36a4b 100644
--- a/drivers/net/macvlan.c
+++ b/drivers/net/macvlan.c
@@ -1385,7 +1385,7 @@  static int macvlan_changelink_sources(struct macvlan_dev *vlan, u32 mode,
 				return ret;
 		}
 
-		if (!data || !data[IFLA_MACVLAN_MACADDR_DATA])
+		if (!data[IFLA_MACVLAN_MACADDR_DATA])
 			return 0;
 
 		head = nla_data(data[IFLA_MACVLAN_MACADDR_DATA]);