| Message ID | 20210108031248.20520-5-michael.wei.hong.sit@intel.com |
|---|---|
| State | Accepted |
| Commit | 9ddaa1e6181b3d33080f2ed7c27cb0bba819e562 |
| Headers | show |
| Series | Enable DMA mode on Intel Keem Bay platform | expand |
On Fri, Jan 08, 2021 at 11:12:47AM +0800, Michael Sit Wei Hong wrote: > Add descriptions for entries needed for audio device to use DMA > channels for audio playback and capture. Please use get_maintainers.pl so patches go to the right lists. This binding has errors in linux-next: ./Documentation/devicetree/bindings/sound/intel,keembay-i2s.yaml: while parsing a block mapping in "<unicode string>", line 55, column 9 did not find expected key in "<unicode string>", line 55, column 27 > > Signed-off-by: Michael Sit Wei Hong <michael.wei.hong.sit@intel.com> > Reviewed-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com> > --- > .../bindings/sound/intel,keembay-i2s.yaml | 14 ++++++++++++++ > 1 file changed, 14 insertions(+) > > diff --git a/Documentation/devicetree/bindings/sound/intel,keembay-i2s.yaml b/Documentation/devicetree/bindings/sound/intel,keembay-i2s.yaml > index d346e61ab708..e0658f122cbb 100644 > --- a/Documentation/devicetree/bindings/sound/intel,keembay-i2s.yaml > +++ b/Documentation/devicetree/bindings/sound/intel,keembay-i2s.yaml > @@ -45,6 +45,18 @@ properties: > - const: osc > - const: apb_clk > > + dmas: > + items: > + - description: DMA controller phandle and DMA channel > + for TX and RX This defines 'dmas' has 1 entry. > + > + dma-names: > + items: > + - description: "tx" for the transmit channel The quotes are what cause the above problem. > + "rx" for the receive channel > + - const: tx > + - const: rx And here dma-names has 3 entries. Drop 'description' because it just says what the schema defines. Please send incremental fixes as Mark already applied. Rob
diff --git a/Documentation/devicetree/bindings/sound/intel,keembay-i2s.yaml b/Documentation/devicetree/bindings/sound/intel,keembay-i2s.yaml index d346e61ab708..e0658f122cbb 100644 --- a/Documentation/devicetree/bindings/sound/intel,keembay-i2s.yaml +++ b/Documentation/devicetree/bindings/sound/intel,keembay-i2s.yaml @@ -45,6 +45,18 @@ properties: - const: osc - const: apb_clk + dmas: + items: + - description: DMA controller phandle and DMA channel + for TX and RX + + dma-names: + items: + - description: "tx" for the transmit channel + "rx" for the receive channel + - const: tx + - const: rx + required: - compatible - "#sound-dai-cells" @@ -70,4 +82,6 @@ examples: interrupts = <GIC_SPI 120 IRQ_TYPE_LEVEL_HIGH>; clock-names = "osc", "apb_clk"; clocks = <&scmi_clk KEEM_BAY_PSS_AUX_I2S3>, <&scmi_clk KEEM_BAY_PSS_I2S3>; + dmas = <&axi_dma0 29 &axi_dma0 33>; + dma-names = "tx", "rx"; };