diff mbox

[05/11] KVM: vgic: return int instead of bool when checking I/O ranges

Message ID 1409062410-25891-6-git-send-email-will.deacon@arm.com
State Superseded
Headers show

Commit Message

Will Deacon Aug. 26, 2014, 2:13 p.m. UTC
vgic_ioaddr_overlap claims to return a bool, but in reality it returns
an int. Shut sparse up by fixing the type signature.

Cc: Christoffer Dall <christoffer.dall@linaro.org>
Cc: Marc Zyngier <marc.zyngier@arm.com>
Signed-off-by: Will Deacon <will.deacon@arm.com>
---
 virt/kvm/arm/vgic.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Marc Zyngier Aug. 26, 2014, 2:27 p.m. UTC | #1
On 26/08/14 15:13, Will Deacon wrote:
> vgic_ioaddr_overlap claims to return a bool, but in reality it returns
> an int. Shut sparse up by fixing the type signature.
> 
> Cc: Christoffer Dall <christoffer.dall@linaro.org>
> Cc: Marc Zyngier <marc.zyngier@arm.com>
> Signed-off-by: Will Deacon <will.deacon@arm.com>

Acked-by: Marc Zyngier <marc.zyngier@arm.com>

	M.

> ---
>  virt/kvm/arm/vgic.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/virt/kvm/arm/vgic.c b/virt/kvm/arm/vgic.c
> index 73eba793b17f..d1cfe672b9d7 100644
> --- a/virt/kvm/arm/vgic.c
> +++ b/virt/kvm/arm/vgic.c
> @@ -1690,7 +1690,7 @@ out:
>  	return ret;
>  }
>  
> -static bool vgic_ioaddr_overlap(struct kvm *kvm)
> +static int vgic_ioaddr_overlap(struct kvm *kvm)
>  {
>  	phys_addr_t dist = kvm->arch.vgic.vgic_dist_base;
>  	phys_addr_t cpu = kvm->arch.vgic.vgic_cpu_base;
>
Christoffer Dall Aug. 26, 2014, 2:49 p.m. UTC | #2
On Tue, Aug 26, 2014 at 03:13:24PM +0100, Will Deacon wrote:
> vgic_ioaddr_overlap claims to return a bool, but in reality it returns
> an int. Shut sparse up by fixing the type signature.
> 
> Cc: Christoffer Dall <christoffer.dall@linaro.org>
> Cc: Marc Zyngier <marc.zyngier@arm.com>
> Signed-off-by: Will Deacon <will.deacon@arm.com>

Acked-by: Christoffer Dall <christoffer.dall@linaro.org>
diff mbox

Patch

diff --git a/virt/kvm/arm/vgic.c b/virt/kvm/arm/vgic.c
index 73eba793b17f..d1cfe672b9d7 100644
--- a/virt/kvm/arm/vgic.c
+++ b/virt/kvm/arm/vgic.c
@@ -1690,7 +1690,7 @@  out:
 	return ret;
 }
 
-static bool vgic_ioaddr_overlap(struct kvm *kvm)
+static int vgic_ioaddr_overlap(struct kvm *kvm)
 {
 	phys_addr_t dist = kvm->arch.vgic.vgic_dist_base;
 	phys_addr_t cpu = kvm->arch.vgic.vgic_cpu_base;