[1/5] rtlwifi: rtl_pci: fix bool comparison in expressions

Message ID 20210110121525.2407-2-yashsri421@gmail.com
State New
Headers show
Series
  • rtlwifi: fix bool comparison in expressions
Related show

Commit Message

Aditya Srivastava Jan. 10, 2021, 12:15 p.m.
There are certain conditional expressions in rtl_pci, where a boolean
variable is compared with true/false, in forms such as (foo == true) or
(false != bar), which does not comply with checkpatch.pl (CHECK:
BOOL_COMPARISON), according to which boolean variables should be
themselves used in the condition, rather than comparing with true/false

E.g., in drivers/net/wireless/realtek/rtlwifi/ps.c,
"if (find_p2p_ie == true)" can be replaced with "if (find_p2p_ie)"

Replace all such expressions with the bool variables appropriately

Signed-off-by: Aditya Srivastava <yashsri421@gmail.com>
---
 drivers/net/wireless/realtek/rtlwifi/ps.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Kalle Valo Jan. 25, 2021, 2:22 p.m. | #1
Aditya Srivastava <yashsri421@gmail.com> wrote:

> There are certain conditional expressions in rtl_pci, where a boolean

> variable is compared with true/false, in forms such as (foo == true) or

> (false != bar), which does not comply with checkpatch.pl (CHECK:

> BOOL_COMPARISON), according to which boolean variables should be

> themselves used in the condition, rather than comparing with true/false

> 

> E.g., in drivers/net/wireless/realtek/rtlwifi/ps.c,

> "if (find_p2p_ie == true)" can be replaced with "if (find_p2p_ie)"

> 

> Replace all such expressions with the bool variables appropriately

> 

> Signed-off-by: Aditya Srivastava <yashsri421@gmail.com>


5 patches applied to wireless-drivers-next.git, thanks.

d8cbaa3de403 rtlwifi: rtl_pci: fix bool comparison in expressions
f7c76283fc5f rtlwifi: rtl8192c-common: fix bool comparison in expressions
64338f0dfd6a rtlwifi: rtl8188ee: fix bool comparison in expressions
33ae4623d544 rtlwifi: rtl8192se: fix bool comparison in expressions
9264cabc1204 rtlwifi: rtl8821ae: fix bool comparison in expressions

-- 
https://patchwork.kernel.org/project/linux-wireless/patch/20210110121525.2407-2-yashsri421@gmail.com/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches

Patch

diff --git a/drivers/net/wireless/realtek/rtlwifi/ps.c b/drivers/net/wireless/realtek/rtlwifi/ps.c
index f99882255d48..629c03271bde 100644
--- a/drivers/net/wireless/realtek/rtlwifi/ps.c
+++ b/drivers/net/wireless/realtek/rtlwifi/ps.c
@@ -798,9 +798,9 @@  static void rtl_p2p_noa_ie(struct ieee80211_hw *hw, void *data,
 		ie += 3 + noa_len;
 	}
 
-	if (find_p2p_ie == true) {
+	if (find_p2p_ie) {
 		if ((p2pinfo->p2p_ps_mode > P2P_PS_NONE) &&
-		    (find_p2p_ps_ie == false))
+		    (!find_p2p_ps_ie))
 			rtl_p2p_ps_cmd(hw, P2P_PS_DISABLE);
 	}
 }