| Message ID | 20210111191926.3688443-26-lee.jones@linaro.org |
|---|---|
| State | Accepted |
| Commit | 0a91c7c32ee6b0fc83aa98b07a1a59837c5c0be6 |
| Headers | show |
| Series | Rid W=1 warnings from GPU | expand |
On Mon, Jan 11, 2021 at 2:20 PM Lee Jones <lee.jones@linaro.org> wrote: > > Fixes the following W=1 kernel build warning(s): > > drivers/gpu/drm/amd/amdgpu/../display/dc/dce120/dce120_timing_generator.c:602:13: warning: ‘dce120_timing_generator_get_position’ defined but not used [-Wunused-function] > > Cc: Harry Wentland <harry.wentland@amd.com> > Cc: Leo Li <sunpeng.li@amd.com> > Cc: Alex Deucher <alexander.deucher@amd.com> > Cc: "Christian König" <christian.koenig@amd.com> > Cc: David Airlie <airlied@linux.ie> > Cc: Daniel Vetter <daniel@ffwll.ch> > Cc: Lee Jones <lee.jones@linaro.org> > Cc: amd-gfx@lists.freedesktop.org > Cc: dri-devel@lists.freedesktop.org > Signed-off-by: Lee Jones <lee.jones@linaro.org> Applied. Thanks! Alex > --- > .../dc/dce120/dce120_timing_generator.c | 43 ------------------- > 1 file changed, 43 deletions(-) > > diff --git a/drivers/gpu/drm/amd/display/dc/dce120/dce120_timing_generator.c b/drivers/gpu/drm/amd/display/dc/dce120/dce120_timing_generator.c > index d02ecb983c9cd..b57c466124e76 100644 > --- a/drivers/gpu/drm/amd/display/dc/dce120/dce120_timing_generator.c > +++ b/drivers/gpu/drm/amd/display/dc/dce120/dce120_timing_generator.c > @@ -589,49 +589,6 @@ static void dce120_timing_generator_set_drr( > } > } > > -/* > - ***************************************************************************** > - * Function: dce120_timing_generator_get_position > - * > - * @brief > - * Returns CRTC vertical/horizontal counters > - * > - * @param [out] position > - ***************************************************************************** > - */ > -static void dce120_timing_generator_get_position(struct timing_generator *tg, > - struct crtc_position *position) > -{ > - uint32_t value; > - struct dce110_timing_generator *tg110 = DCE110TG_FROM_TG(tg); > - > - value = dm_read_reg_soc15( > - tg->ctx, > - mmCRTC0_CRTC_STATUS_POSITION, > - tg110->offsets.crtc); > - > - position->horizontal_count = get_reg_field_value( > - value, > - CRTC0_CRTC_STATUS_POSITION, > - CRTC_HORZ_COUNT); > - > - position->vertical_count = get_reg_field_value( > - value, > - CRTC0_CRTC_STATUS_POSITION, > - CRTC_VERT_COUNT); > - > - value = dm_read_reg_soc15( > - tg->ctx, > - mmCRTC0_CRTC_NOM_VERT_POSITION, > - tg110->offsets.crtc); > - > - position->nominal_vcount = get_reg_field_value( > - value, > - CRTC0_CRTC_NOM_VERT_POSITION, > - CRTC_VERT_COUNT_NOM); > -} > - > - > static void dce120_timing_generator_get_crtc_scanoutpos( > struct timing_generator *tg, > uint32_t *v_blank_start, > -- > 2.25.1 > > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel
diff --git a/drivers/gpu/drm/amd/display/dc/dce120/dce120_timing_generator.c b/drivers/gpu/drm/amd/display/dc/dce120/dce120_timing_generator.c index d02ecb983c9cd..b57c466124e76 100644 --- a/drivers/gpu/drm/amd/display/dc/dce120/dce120_timing_generator.c +++ b/drivers/gpu/drm/amd/display/dc/dce120/dce120_timing_generator.c @@ -589,49 +589,6 @@ static void dce120_timing_generator_set_drr( } } -/* - ***************************************************************************** - * Function: dce120_timing_generator_get_position - * - * @brief - * Returns CRTC vertical/horizontal counters - * - * @param [out] position - ***************************************************************************** - */ -static void dce120_timing_generator_get_position(struct timing_generator *tg, - struct crtc_position *position) -{ - uint32_t value; - struct dce110_timing_generator *tg110 = DCE110TG_FROM_TG(tg); - - value = dm_read_reg_soc15( - tg->ctx, - mmCRTC0_CRTC_STATUS_POSITION, - tg110->offsets.crtc); - - position->horizontal_count = get_reg_field_value( - value, - CRTC0_CRTC_STATUS_POSITION, - CRTC_HORZ_COUNT); - - position->vertical_count = get_reg_field_value( - value, - CRTC0_CRTC_STATUS_POSITION, - CRTC_VERT_COUNT); - - value = dm_read_reg_soc15( - tg->ctx, - mmCRTC0_CRTC_NOM_VERT_POSITION, - tg110->offsets.crtc); - - position->nominal_vcount = get_reg_field_value( - value, - CRTC0_CRTC_NOM_VERT_POSITION, - CRTC_VERT_COUNT_NOM); -} - - static void dce120_timing_generator_get_crtc_scanoutpos( struct timing_generator *tg, uint32_t *v_blank_start,
Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/amd/amdgpu/../display/dc/dce120/dce120_timing_generator.c:602:13: warning: ‘dce120_timing_generator_get_position’ defined but not used [-Wunused-function] Cc: Harry Wentland <harry.wentland@amd.com> Cc: Leo Li <sunpeng.li@amd.com> Cc: Alex Deucher <alexander.deucher@amd.com> Cc: "Christian König" <christian.koenig@amd.com> Cc: David Airlie <airlied@linux.ie> Cc: Daniel Vetter <daniel@ffwll.ch> Cc: Lee Jones <lee.jones@linaro.org> Cc: amd-gfx@lists.freedesktop.org Cc: dri-devel@lists.freedesktop.org Signed-off-by: Lee Jones <lee.jones@linaro.org> --- .../dc/dce120/dce120_timing_generator.c | 43 ------------------- 1 file changed, 43 deletions(-)