| Message ID | 20210110194851.10207-1-jbx6244@gmail.com |
|---|---|
| State | Accepted |
| Commit | 060b65d260c5867ca9f56e275d8dbc3f5dba1c13 |
| Headers | show |
| Series | arm64: dts: rockchip: rename pinctrl nodename to gmac2io for nanopi-r2s board | expand |
Hi Rob, On Mon, Jan 11, 2021 at 3:50 AM Johan Jonker <jbx6244@gmail.com> wrote: > > A test with the command below gives this error: > /arch/arm64/boot/dts/rockchip/rk3328-nanopi-r2s.dt.yaml: > ethernet-phy: 'reg' is a required property > > The pinctrl nodename "ethernet-phy" conflicts with the rules > in the "ethernet-phy.yaml" document, so rename it to "gmac2io". This seems more like an unintended side effect of the ethernet-phy binding. Is there a way to limit the matching of the binding only if the parent is an "mdio" or "ethernet" node? Would that make more sense? Regards ChenYu > make ARCH=arm64 dtbs_check > DT_SCHEMA_FILES=Documentation/devicetree/bindings/net/ethernet-phy.yaml > > Signed-off-by: Johan Jonker <jbx6244@gmail.com> > --- > arch/arm64/boot/dts/rockchip/rk3328-nanopi-r2s.dts | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm64/boot/dts/rockchip/rk3328-nanopi-r2s.dts b/arch/arm64/boot/dts/rockchip/rk3328-nanopi-r2s.dts > index 2ee07d15a..86732b45d 100644 > --- a/arch/arm64/boot/dts/rockchip/rk3328-nanopi-r2s.dts > +++ b/arch/arm64/boot/dts/rockchip/rk3328-nanopi-r2s.dts > @@ -280,7 +280,7 @@ > }; > }; > > - ethernet-phy { > + gmac2io { > eth_phy_reset_pin: eth-phy-reset-pin { > rockchip,pins = <1 RK_PC2 RK_FUNC_GPIO &pcfg_pull_down>; > }; > -- > 2.11.0 > > > _______________________________________________ > linux-arm-kernel mailing list > linux-arm-kernel@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
On Sun, 10 Jan 2021 20:48:51 +0100, Johan Jonker wrote: > A test with the command below gives this error: > /arch/arm64/boot/dts/rockchip/rk3328-nanopi-r2s.dt.yaml: > ethernet-phy: 'reg' is a required property > > The pinctrl nodename "ethernet-phy" conflicts with the rules > in the "ethernet-phy.yaml" document, so rename it to "gmac2io". > > [...] Applied, thanks! [1/1] arm64: dts: rockchip: rename pinctrl nodename to gmac2io for nanopi-r2s board commit: 16459ecac6d6bf6a817d9c0cf78d696461fdcd26 Best regards, -- Heiko Stuebner <heiko@sntech.de>
diff --git a/arch/arm64/boot/dts/rockchip/rk3328-nanopi-r2s.dts b/arch/arm64/boot/dts/rockchip/rk3328-nanopi-r2s.dts index 2ee07d15a..86732b45d 100644 --- a/arch/arm64/boot/dts/rockchip/rk3328-nanopi-r2s.dts +++ b/arch/arm64/boot/dts/rockchip/rk3328-nanopi-r2s.dts @@ -280,7 +280,7 @@ }; }; - ethernet-phy { + gmac2io { eth_phy_reset_pin: eth-phy-reset-pin { rockchip,pins = <1 RK_PC2 RK_FUNC_GPIO &pcfg_pull_down>; };
A test with the command below gives this error: /arch/arm64/boot/dts/rockchip/rk3328-nanopi-r2s.dt.yaml: ethernet-phy: 'reg' is a required property The pinctrl nodename "ethernet-phy" conflicts with the rules in the "ethernet-phy.yaml" document, so rename it to "gmac2io". make ARCH=arm64 dtbs_check DT_SCHEMA_FILES=Documentation/devicetree/bindings/net/ethernet-phy.yaml Signed-off-by: Johan Jonker <jbx6244@gmail.com> --- arch/arm64/boot/dts/rockchip/rk3328-nanopi-r2s.dts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)