diff mbox series

rtw88: debug: style: Simplify bool comparison

Message ID 1610356932-56073-1-git-send-email-abaci-bugfix@linux.alibaba.com
State Superseded
Headers show
Series rtw88: debug: style: Simplify bool comparison | expand

Commit Message

Abaci Team Jan. 11, 2021, 9:22 a.m. UTC
Fix the following coccicheck warning:
 ./drivers/net/wireless/realtek/rtw88/debug.c:800:17-23: WARNING:
Comparison of 0/1 to bool variable

Signed-off-by: YANG LI <abaci-bugfix@linux.alibaba.com>
Reported-by: Abaci Robot<abaci@linux.alibaba.com>
---
 drivers/net/wireless/realtek/rtw88/debug.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Ping-Ke Shih Jan. 12, 2021, 2:20 a.m. UTC | #1
On Mon, 2021-01-11 at 09:22 +0000, YANG LI wrote:
> Fix the following coccicheck warning:

>  ./drivers/net/wireless/realtek/rtw88/debug.c:800:17-23: WARNING:

> Comparison of 0/1 to bool variable

> 

> Signed-off-by: YANG LI <abaci-bugfix@linux.alibaba.com>

> Reported-by: Abaci Robot<abaci@linux.alibaba.com>---

>  drivers/net/wireless/realtek/rtw88/debug.c | 2 +-

>  1 file changed, 1 insertion(+), 1 deletion(-)

> 

> 


I think that "rtw88:" or "rtw88: debug:" as subject prefix is enough.
Others are good to me.

---
Ping-Ke
diff mbox series

Patch

diff --git a/drivers/net/wireless/realtek/rtw88/debug.c b/drivers/net/wireless/realtek/rtw88/debug.c
index 19fc2d8..948cb79 100644
--- a/drivers/net/wireless/realtek/rtw88/debug.c
+++ b/drivers/net/wireless/realtek/rtw88/debug.c
@@ -800,7 +800,7 @@  static ssize_t rtw_debugfs_set_coex_enable(struct file *filp,
 	}
 
 	mutex_lock(&rtwdev->mutex);
-	coex->manual_control = enable == 0;
+	coex->manual_control = !enable;
 	mutex_unlock(&rtwdev->mutex);
 
 	return count;