pinctrl: sprd: style: Simplify bool comparison

Message ID 1610440080-68600-1-git-send-email-abaci-bugfix@linux.alibaba.com
State New
Headers show
Series
  • pinctrl: sprd: style: Simplify bool comparison
Related show

Commit Message

Abaci Team Jan. 12, 2021, 8:28 a.m.
Fix the following coccicheck warning:
./drivers/pinctrl/sprd/pinctrl-sprd.c:690:8-23: WARNING: Comparison to
bool

Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Signed-off-by: YANG LI <abaci-bugfix@linux.alibaba.com>
---
 drivers/pinctrl/sprd/pinctrl-sprd.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Baolin Wang Jan. 13, 2021, 1:55 a.m. | #1
On Tue, Jan 12, 2021 at 4:28 PM YANG LI <abaci-bugfix@linux.alibaba.com> wrote:
>

> Fix the following coccicheck warning:

> ./drivers/pinctrl/sprd/pinctrl-sprd.c:690:8-23: WARNING: Comparison to

> bool

>

> Reported-by: Abaci Robot <abaci@linux.alibaba.com>

> Signed-off-by: YANG LI <abaci-bugfix@linux.alibaba.com>


The subject line should be "pinctrl: sprd: Simplify xxx", otherwise
Reviewed-by: Baolin Wang <baolin.wang7@gmail.com>


> ---

>  drivers/pinctrl/sprd/pinctrl-sprd.c | 2 +-

>  1 file changed, 1 insertion(+), 1 deletion(-)

>

> diff --git a/drivers/pinctrl/sprd/pinctrl-sprd.c b/drivers/pinctrl/sprd/pinctrl-sprd.c

> index 08dc193..dca7a50 100644

> --- a/drivers/pinctrl/sprd/pinctrl-sprd.c

> +++ b/drivers/pinctrl/sprd/pinctrl-sprd.c

> @@ -687,7 +687,7 @@ static int sprd_pinconf_set(struct pinctrl_dev *pctldev, unsigned int pin_id,

>                                 shift = INPUT_SCHMITT_SHIFT;

>                                 break;

>                         case PIN_CONFIG_BIAS_PULL_UP:

> -                               if (is_sleep_config == true) {

> +                               if (is_sleep_config) {

>                                         val |= SLEEP_PULL_UP;

>                                         mask = SLEEP_PULL_UP_MASK;

>                                         shift = SLEEP_PULL_UP_SHIFT;

> --

> 1.8.3.1

>



-- 
Baolin Wang
Linus Walleij Jan. 18, 2021, 1:42 p.m. | #2
On Tue, Jan 12, 2021 at 9:28 AM YANG LI <abaci-bugfix@linux.alibaba.com> wrote:

> Fix the following coccicheck warning:

> ./drivers/pinctrl/sprd/pinctrl-sprd.c:690:8-23: WARNING: Comparison to

> bool

>

> Reported-by: Abaci Robot <abaci@linux.alibaba.com>

> Signed-off-by: YANG LI <abaci-bugfix@linux.alibaba.com>


Patch applied, fixing subject as indicated by Baolin.

First fix I get from Alibabas robot :)

Yours,
Linus Walleij

Patch

diff --git a/drivers/pinctrl/sprd/pinctrl-sprd.c b/drivers/pinctrl/sprd/pinctrl-sprd.c
index 08dc193..dca7a50 100644
--- a/drivers/pinctrl/sprd/pinctrl-sprd.c
+++ b/drivers/pinctrl/sprd/pinctrl-sprd.c
@@ -687,7 +687,7 @@  static int sprd_pinconf_set(struct pinctrl_dev *pctldev, unsigned int pin_id,
 				shift = INPUT_SCHMITT_SHIFT;
 				break;
 			case PIN_CONFIG_BIAS_PULL_UP:
-				if (is_sleep_config == true) {
+				if (is_sleep_config) {
 					val |= SLEEP_PULL_UP;
 					mask = SLEEP_PULL_UP_MASK;
 					shift = SLEEP_PULL_UP_SHIFT;