| Message ID | 20210113060615.53088-2-samuel@sholland.org |
|---|---|
| State | New |
| Headers | show |
| Series | PinePhone BT audio bringup | expand |
Hi, On Wed, Jan 13, 2021 at 12:06:09AM -0600, Samuel Holland wrote: > Increase sound-dai-cells to 1 to allow using the DAIs in the codec > corresponding to AIF2 and AIF3. > > The generic ASoC OF code supports a #sound-dai-cells value of 0 or 1 > with no impact to the driver, so this is a backward-compatible change. > > Signed-off-by: Samuel Holland <samuel@sholland.org> > --- > .../devicetree/bindings/sound/allwinner,sun8i-a33-codec.yaml | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/Documentation/devicetree/bindings/sound/allwinner,sun8i-a33-codec.yaml b/Documentation/devicetree/bindings/sound/allwinner,sun8i-a33-codec.yaml > index 67405e6d8168..3e02baa1d9ce 100644 > --- a/Documentation/devicetree/bindings/sound/allwinner,sun8i-a33-codec.yaml > +++ b/Documentation/devicetree/bindings/sound/allwinner,sun8i-a33-codec.yaml > @@ -12,7 +12,7 @@ maintainers: > > properties: > "#sound-dai-cells": > - const: 0 > + const: 1 We should make it clearer that 0 is still ok, but is deprecated You can do it with: oneOf: - const: 1 - const: 0 deprecated: true description: > Whatever Maxime
diff --git a/Documentation/devicetree/bindings/sound/allwinner,sun8i-a33-codec.yaml b/Documentation/devicetree/bindings/sound/allwinner,sun8i-a33-codec.yaml index 67405e6d8168..3e02baa1d9ce 100644 --- a/Documentation/devicetree/bindings/sound/allwinner,sun8i-a33-codec.yaml +++ b/Documentation/devicetree/bindings/sound/allwinner,sun8i-a33-codec.yaml @@ -12,7 +12,7 @@ maintainers: properties: "#sound-dai-cells": - const: 0 + const: 1 compatible: oneOf: @@ -50,7 +50,7 @@ additionalProperties: false examples: - | audio-codec@1c22e00 { - #sound-dai-cells = <0>; + #sound-dai-cells = <1>; compatible = "allwinner,sun8i-a33-codec"; reg = <0x01c22e00 0x400>; interrupts = <0 29 4>;
Increase sound-dai-cells to 1 to allow using the DAIs in the codec corresponding to AIF2 and AIF3. The generic ASoC OF code supports a #sound-dai-cells value of 0 or 1 with no impact to the driver, so this is a backward-compatible change. Signed-off-by: Samuel Holland <samuel@sholland.org> --- .../devicetree/bindings/sound/allwinner,sun8i-a33-codec.yaml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)