| Message ID | 20210113194952.104734-1-u.kleine-koenig@pengutronix.de |
|---|---|
| State | New |
| Headers | show |
| Series | [1/2] gpio: pca953x: Add support for pca9506 | expand |
On Wed, Jan 13, 2021 at 8:50 PM Uwe Kleine-König <u.kleine-koenig@pengutronix.de> wrote: > > According to the reference manual "The PCA9505 is identical to the > PCA9506 except that it includes 100 kΩ internal pull-up resistors on all > the I/Os." So the pca9506 device can be considered identical to the > pca9505 for the gpio driver. > > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> > --- > Documentation/devicetree/bindings/gpio/gpio-pca95xx.yaml | 1 + > drivers/gpio/gpio-pca953x.c | 2 ++ > 2 files changed, 3 insertions(+) > > diff --git a/Documentation/devicetree/bindings/gpio/gpio-pca95xx.yaml b/Documentation/devicetree/bindings/gpio/gpio-pca95xx.yaml > index f5ee23c2df60..cdd7744b8723 100644 > --- a/Documentation/devicetree/bindings/gpio/gpio-pca95xx.yaml > +++ b/Documentation/devicetree/bindings/gpio/gpio-pca95xx.yaml > @@ -32,6 +32,7 @@ properties: > - maxim,max7327 > - nxp,pca6416 > - nxp,pca9505 > + - nxp,pca9506 > - nxp,pca9534 > - nxp,pca9535 > - nxp,pca9536 > diff --git a/drivers/gpio/gpio-pca953x.c b/drivers/gpio/gpio-pca953x.c > index 825b362eb4b7..5ea09fd01544 100644 > --- a/drivers/gpio/gpio-pca953x.c > +++ b/drivers/gpio/gpio-pca953x.c > @@ -73,6 +73,7 @@ > static const struct i2c_device_id pca953x_id[] = { > { "pca6416", 16 | PCA953X_TYPE | PCA_INT, }, > { "pca9505", 40 | PCA953X_TYPE | PCA_INT, }, > + { "pca9506", 40 | PCA953X_TYPE | PCA_INT, }, > { "pca9534", 8 | PCA953X_TYPE | PCA_INT, }, > { "pca9535", 16 | PCA953X_TYPE | PCA_INT, }, > { "pca9536", 4 | PCA953X_TYPE, }, > @@ -1236,6 +1237,7 @@ static int pca953x_resume(struct device *dev) > static const struct of_device_id pca953x_dt_ids[] = { > { .compatible = "nxp,pca6416", .data = OF_953X(16, PCA_INT), }, > { .compatible = "nxp,pca9505", .data = OF_953X(40, PCA_INT), }, > + { .compatible = "nxp,pca9506", .data = OF_953X(40, PCA_INT), }, > { .compatible = "nxp,pca9534", .data = OF_953X( 8, PCA_INT), }, > { .compatible = "nxp,pca9535", .data = OF_953X(16, PCA_INT), }, > { .compatible = "nxp,pca9536", .data = OF_953X( 4, 0), }, > > base-commit: 5c8fe583cce542aa0b84adc939ce85293de36e5e > -- > 2.29.2 > Hi Uwe, This looks good but we usually split the DT bindings and code changes into separate patches. Would you mind resending? Bart
On Wed, Jan 13, 2021 at 8:50 PM Uwe Kleine-König <u.kleine-koenig@pengutronix.de> wrote: > Some supported chips (e.g. pca9505) support 40 chips. To be able to give 40 lines I guess? (No big deal. Everyone understand what you mean.) > each line a name the length of the gpio-line-names property must be > allowed to contain up to 40 entries. > > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> Reviewed-by: Linus Walleij <linus.walleij@linaro.org> Yours, Linus Walleij
On Mon, Jan 18, 2021 at 3:57 PM Uwe Kleine-König <u.kleine-koenig@pengutronix.de> wrote: > Who will pick up this series (preferable v2 instead of this (implicit) > v1)? Will they notice this Reviewed-by? Bartosz is collecting GPIO patches to Torvalds for this merge window. Yours, Linus Walleij
On Fri, Jan 22, 2021 at 10:50 AM Linus Walleij <linus.walleij@linaro.org> wrote: > > On Mon, Jan 18, 2021 at 3:57 PM Uwe Kleine-König > <u.kleine-koenig@pengutronix.de> wrote: > > > Who will pick up this series (preferable v2 instead of this (implicit) > > v1)? Will they notice this Reviewed-by? > > Bartosz is collecting GPIO patches to Torvalds for this merge > window. > > Yours, > Linus Walleij I already have v2 of this series in my tree. Bartosz
diff --git a/Documentation/devicetree/bindings/gpio/gpio-pca95xx.yaml b/Documentation/devicetree/bindings/gpio/gpio-pca95xx.yaml index f5ee23c2df60..cdd7744b8723 100644 --- a/Documentation/devicetree/bindings/gpio/gpio-pca95xx.yaml +++ b/Documentation/devicetree/bindings/gpio/gpio-pca95xx.yaml @@ -32,6 +32,7 @@ properties: - maxim,max7327 - nxp,pca6416 - nxp,pca9505 + - nxp,pca9506 - nxp,pca9534 - nxp,pca9535 - nxp,pca9536 diff --git a/drivers/gpio/gpio-pca953x.c b/drivers/gpio/gpio-pca953x.c index 825b362eb4b7..5ea09fd01544 100644 --- a/drivers/gpio/gpio-pca953x.c +++ b/drivers/gpio/gpio-pca953x.c @@ -73,6 +73,7 @@ static const struct i2c_device_id pca953x_id[] = { { "pca6416", 16 | PCA953X_TYPE | PCA_INT, }, { "pca9505", 40 | PCA953X_TYPE | PCA_INT, }, + { "pca9506", 40 | PCA953X_TYPE | PCA_INT, }, { "pca9534", 8 | PCA953X_TYPE | PCA_INT, }, { "pca9535", 16 | PCA953X_TYPE | PCA_INT, }, { "pca9536", 4 | PCA953X_TYPE, }, @@ -1236,6 +1237,7 @@ static int pca953x_resume(struct device *dev) static const struct of_device_id pca953x_dt_ids[] = { { .compatible = "nxp,pca6416", .data = OF_953X(16, PCA_INT), }, { .compatible = "nxp,pca9505", .data = OF_953X(40, PCA_INT), }, + { .compatible = "nxp,pca9506", .data = OF_953X(40, PCA_INT), }, { .compatible = "nxp,pca9534", .data = OF_953X( 8, PCA_INT), }, { .compatible = "nxp,pca9535", .data = OF_953X(16, PCA_INT), }, { .compatible = "nxp,pca9536", .data = OF_953X( 4, 0), },
According to the reference manual "The PCA9505 is identical to the PCA9506 except that it includes 100 kΩ internal pull-up resistors on all the I/Os." So the pca9506 device can be considered identical to the pca9505 for the gpio driver. Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> --- Documentation/devicetree/bindings/gpio/gpio-pca95xx.yaml | 1 + drivers/gpio/gpio-pca953x.c | 2 ++ 2 files changed, 3 insertions(+) base-commit: 5c8fe583cce542aa0b84adc939ce85293de36e5e