diff mbox series

[v2] rtw88: Simplify bool comparison

Message ID 1610445040-23599-1-git-send-email-abaci-bugfix@linux.alibaba.com
State New
Headers show
Series [v2] rtw88: Simplify bool comparison | expand

Commit Message

Abaci Team Jan. 12, 2021, 9:50 a.m. UTC
Fix the following coccicheck warning:
 ./drivers/net/wireless/realtek/rtw88/debug.c:800:17-23: WARNING:
Comparison of 0/1 to bool variable

Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Signed-off-by: YANG LI <abaci-bugfix@linux.alibaba.com>
---
Changes in v2:

make "rtw88:" as subject prefix

 drivers/net/wireless/realtek/rtw88/debug.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Kalle Valo Jan. 14, 2021, 5:27 p.m. UTC | #1
YANG LI <abaci-bugfix@linux.alibaba.com> wrote:

> Fix the following coccicheck warning:

>  ./drivers/net/wireless/realtek/rtw88/debug.c:800:17-23: WARNING:

> Comparison of 0/1 to bool variable

> 

> Reported-by: Abaci Robot <abaci@linux.alibaba.com>

> Signed-off-by: YANG LI <abaci-bugfix@linux.alibaba.com>


Patch applied to wireless-drivers-next.git, thanks.

d3a78c7a9daa rtw88: Simplify bool comparison

-- 
https://patchwork.kernel.org/project/linux-wireless/patch/1610445040-23599-1-git-send-email-abaci-bugfix@linux.alibaba.com/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
diff mbox series

Patch

diff --git a/drivers/net/wireless/realtek/rtw88/debug.c b/drivers/net/wireless/realtek/rtw88/debug.c
index 19fc2d8..948cb79 100644
--- a/drivers/net/wireless/realtek/rtw88/debug.c
+++ b/drivers/net/wireless/realtek/rtw88/debug.c
@@ -800,7 +800,7 @@  static ssize_t rtw_debugfs_set_coex_enable(struct file *filp,
 	}
 
 	mutex_lock(&rtwdev->mutex);
-	coex->manual_control = enable == 0;
+	coex->manual_control = !enable;
 	mutex_unlock(&rtwdev->mutex);
 
 	return count;