| Message ID | 1409532820-5027-4-git-send-email-lersek@redhat.com |
|---|---|
| State | Superseded |
| Headers | show |
On Mon, 01 Sep, at 02:53:38AM, Laszlo Ersek wrote: > Signed-off-by: Laszlo Ersek <lersek@redhat.com> > --- > arch/x86/platform/efi/efi.c | 7 +++++-- > 1 file changed, 5 insertions(+), 2 deletions(-) I know this is a straight forward patch in the context of this series, but you need to include a rationale, so that we know in 6 months, 12 months and 5 years from now why this change made sense. Something like, "Reduce the amount of duplicated code by using the helper function" would be fine.
diff --git a/arch/x86/platform/efi/efi.c b/arch/x86/platform/efi/efi.c index 850da94..ae2573a 100644 --- a/arch/x86/platform/efi/efi.c +++ b/arch/x86/platform/efi/efi.c @@ -210,9 +210,12 @@ static void __init print_efi_memmap(void) for (p = memmap.map, i = 0; p < memmap.map_end; p += memmap.desc_size, i++) { + char buf[64]; + md = p; - pr_info("mem%02u: type=%u, attr=0x%llx, range=[0x%016llx-0x%016llx) (%lluMB)\n", - i, md->type, md->attribute, md->phys_addr, + pr_info("mem%02u: %s range=[0x%016llx-0x%016llx) (%lluMB)\n", + i, efi_md_typeattr_format(buf, sizeof(buf), md), + md->phys_addr, md->phys_addr + (md->num_pages << EFI_PAGE_SHIFT), (md->num_pages >> (20 - EFI_PAGE_SHIFT))); }
Signed-off-by: Laszlo Ersek <lersek@redhat.com> --- arch/x86/platform/efi/efi.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-)