diff mbox series

[PATCHv2,net-next,2/2] Revert "bareudp: Fixed bareudp receive handling"

Message ID 1984207281c8f03b61968731487cd436dba40b80.1610695758.git.lucien.xin@gmail.com
State Superseded
Headers show
Series net: enable udp v6 sockets receiving v4 packets with UDP GRO | expand

Commit Message

Xin Long Jan. 15, 2021, 7:30 a.m. UTC 
As udp_encap_enable() is already called in udp_tunnel_encap_enable()
since the last patch, and we don't need it any more. So remove it by
reverting commit 81f954a44567567c7d74a97b1db78fb43afc253d.
---
 drivers/net/bareudp.c | 6 ------
 1 file changed, 6 deletions(-)

Comments

Jakub Kicinski Jan. 15, 2021, 10:46 p.m. UTC | #1 
On Fri, 15 Jan 2021 15:30:09 +0800 Xin Long wrote:
> As udp_encap_enable() is already called in udp_tunnel_encap_enable()
> since the last patch, and we don't need it any more. So remove it by
> reverting commit 81f954a44567567c7d74a97b1db78fb43afc253d.

missing signoff on this one
diff mbox series

Patch

diff --git a/drivers/net/bareudp.c b/drivers/net/bareudp.c
index 0965d13..57dfaf4 100644
--- a/drivers/net/bareudp.c
+++ b/drivers/net/bareudp.c
@@ -240,12 +240,6 @@  static int bareudp_socket_create(struct bareudp_dev *bareudp, __be16 port)
 	tunnel_cfg.encap_destroy = NULL;
 	setup_udp_tunnel_sock(bareudp->net, sock, &tunnel_cfg);
 
-	/* As the setup_udp_tunnel_sock does not call udp_encap_enable if the
-	 * socket type is v6 an explicit call to udp_encap_enable is needed.
-	 */
-	if (sock->sk->sk_family == AF_INET6)
-		udp_encap_enable();
-
 	rcu_assign_pointer(bareudp->sock, sock);
 	return 0;
 }