| Message ID | 20210115203951.850873-1-swboyd@chromium.org |
|---|---|
| State | Superseded |
| Headers | show |
| Series | soc: qcom: socinfo: Don't print anything if nothing found | expand |
Hi, On Fri, Jan 15, 2021 at 12:39 PM Stephen Boyd <swboyd@chromium.org> wrote: > > Let's skip printing anything if there's nothing to see. This makes it so > the file length is 0 instead of 1, for the newline, and helps scripts > figure out if there's anything to see in these files. > > Cc: Sai Prakash Ranjan <saiprakash.ranjan@codeaurora.org> > Cc: Douglas Anderson <dianders@chromium.org> > Cc: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> > Signed-off-by: Stephen Boyd <swboyd@chromium.org> > --- > drivers/soc/qcom/socinfo.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) Reviewed-by: Douglas Anderson <dianders@chromium.org>
On 2021-01-16 02:09, Stephen Boyd wrote: > Let's skip printing anything if there's nothing to see. This makes it > so > the file length is 0 instead of 1, for the newline, and helps scripts > figure out if there's anything to see in these files. > > Cc: Sai Prakash Ranjan <saiprakash.ranjan@codeaurora.org> > Cc: Douglas Anderson <dianders@chromium.org> > Cc: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> > Signed-off-by: Stephen Boyd <swboyd@chromium.org> > --- Reviewed-by: Sai Prakash Ranjan <saiprakash.ranjan@codeaurora.org> > drivers/soc/qcom/socinfo.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/soc/qcom/socinfo.c b/drivers/soc/qcom/socinfo.c > index a985ed064669..0844b5d4e354 100644 > --- a/drivers/soc/qcom/socinfo.c > +++ b/drivers/soc/qcom/socinfo.c > @@ -373,8 +373,8 @@ QCOM_OPEN(chip_id, qcom_show_chip_id); > static int show_image_##type(struct seq_file *seq, void *p) \ > { \ > struct smem_image_version *image_version = seq->private; \ > - seq_puts(seq, image_version->type); \ > - seq_putc(seq, '\n'); \ > + if (image_version->type[0] != '\0') \ > + seq_printf(seq, "%s\n", image_version->type); \ > return 0; \ > } \ > static int open_image_##type(struct inode *inode, struct file *file) > \ > > base-commit: 3bc4bf77fa2adca8d6677461b6ec57505f1a3331 -- QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation
diff --git a/drivers/soc/qcom/socinfo.c b/drivers/soc/qcom/socinfo.c index a985ed064669..0844b5d4e354 100644 --- a/drivers/soc/qcom/socinfo.c +++ b/drivers/soc/qcom/socinfo.c @@ -373,8 +373,8 @@ QCOM_OPEN(chip_id, qcom_show_chip_id); static int show_image_##type(struct seq_file *seq, void *p) \ { \ struct smem_image_version *image_version = seq->private; \ - seq_puts(seq, image_version->type); \ - seq_putc(seq, '\n'); \ + if (image_version->type[0] != '\0') \ + seq_printf(seq, "%s\n", image_version->type); \ return 0; \ } \ static int open_image_##type(struct inode *inode, struct file *file) \
Let's skip printing anything if there's nothing to see. This makes it so the file length is 0 instead of 1, for the newline, and helps scripts figure out if there's anything to see in these files. Cc: Sai Prakash Ranjan <saiprakash.ranjan@codeaurora.org> Cc: Douglas Anderson <dianders@chromium.org> Cc: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> Signed-off-by: Stephen Boyd <swboyd@chromium.org> --- drivers/soc/qcom/socinfo.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) base-commit: 3bc4bf77fa2adca8d6677461b6ec57505f1a3331