| Message ID | 1409741551-16437-14-git-send-email-ulf.hansson@linaro.org |
|---|---|
| State | Accepted |
| Commit | f1bf45c70ffdcf048d046da4ad4611315f1a15bf |
| Headers | show |
On Wed, Sep 03, 2014 at 12:52:29PM +0200, Ulf Hansson wrote: > Since genpd at late init, will try to disable unused PM domains we > don't need to do it from here as well. > > Cc: Simon Horman <horms@verge.net.au> > Cc: Magnus Damm <magnus.damm@gmail.com> > Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org> Acked-by: Simon Horman <horms+renesas@verge.net.au> > --- > drivers/sh/pm_runtime.c | 11 ----------- > 1 file changed, 11 deletions(-) > > diff --git a/drivers/sh/pm_runtime.c b/drivers/sh/pm_runtime.c > index 72f6381..fe2c2d5 100644 > --- a/drivers/sh/pm_runtime.c > +++ b/drivers/sh/pm_runtime.c > @@ -75,8 +75,6 @@ static struct pm_clk_notifier_block platform_bus_notifier = { > .con_ids = { NULL, }, > }; > > -static bool default_pm_on; > - > static int __init sh_pm_runtime_init(void) > { > if (IS_ENABLED(CONFIG_ARCH_SHMOBILE_MULTI)) { > @@ -96,16 +94,7 @@ static int __init sh_pm_runtime_init(void) > return 0; > } > > - default_pm_on = true; > pm_clk_add_notifier(&platform_bus_type, &platform_bus_notifier); > return 0; > } > core_initcall(sh_pm_runtime_init); > - > -static int __init sh_pm_runtime_late_init(void) > -{ > - if (default_pm_on) > - pm_genpd_poweroff_unused(); > - return 0; > -} > -late_initcall(sh_pm_runtime_late_init); > -- > 1.9.1 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-sh" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 4 September 2014 02:33, Simon Horman <horms@verge.net.au> wrote: > On Wed, Sep 03, 2014 at 12:52:29PM +0200, Ulf Hansson wrote: >> Since genpd at late init, will try to disable unused PM domains we >> don't need to do it from here as well. >> >> Cc: Simon Horman <horms@verge.net.au> >> Cc: Magnus Damm <magnus.damm@gmail.com> >> Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org> > > > Acked-by: Simon Horman <horms+renesas@verge.net.au> > Simon, thanks for your ack! When you have time, would you please also have a look at the two patches below: [PATCH 04/15] ARM: shmobile: Drop dev_irq_safe from r8a7779 genpd config [PATCH 05/15] ARM: shmobile: Drop dev_irq_safe from R-mobile genpd config Kind regards Uffe >> --- >> drivers/sh/pm_runtime.c | 11 ----------- >> 1 file changed, 11 deletions(-) >> >> diff --git a/drivers/sh/pm_runtime.c b/drivers/sh/pm_runtime.c >> index 72f6381..fe2c2d5 100644 >> --- a/drivers/sh/pm_runtime.c >> +++ b/drivers/sh/pm_runtime.c >> @@ -75,8 +75,6 @@ static struct pm_clk_notifier_block platform_bus_notifier = { >> .con_ids = { NULL, }, >> }; >> >> -static bool default_pm_on; >> - >> static int __init sh_pm_runtime_init(void) >> { >> if (IS_ENABLED(CONFIG_ARCH_SHMOBILE_MULTI)) { >> @@ -96,16 +94,7 @@ static int __init sh_pm_runtime_init(void) >> return 0; >> } >> >> - default_pm_on = true; >> pm_clk_add_notifier(&platform_bus_type, &platform_bus_notifier); >> return 0; >> } >> core_initcall(sh_pm_runtime_init); >> - >> -static int __init sh_pm_runtime_late_init(void) >> -{ >> - if (default_pm_on) >> - pm_genpd_poweroff_unused(); >> - return 0; >> -} >> -late_initcall(sh_pm_runtime_late_init); >> -- >> 1.9.1 >> >> -- >> To unsubscribe from this list: send the line "unsubscribe linux-sh" in >> the body of a message to majordomo@vger.kernel.org >> More majordomo info at http://vger.kernel.org/majordomo-info.html >> -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/sh/pm_runtime.c b/drivers/sh/pm_runtime.c index 72f6381..fe2c2d5 100644 --- a/drivers/sh/pm_runtime.c +++ b/drivers/sh/pm_runtime.c @@ -75,8 +75,6 @@ static struct pm_clk_notifier_block platform_bus_notifier = { .con_ids = { NULL, }, }; -static bool default_pm_on; - static int __init sh_pm_runtime_init(void) { if (IS_ENABLED(CONFIG_ARCH_SHMOBILE_MULTI)) { @@ -96,16 +94,7 @@ static int __init sh_pm_runtime_init(void) return 0; } - default_pm_on = true; pm_clk_add_notifier(&platform_bus_type, &platform_bus_notifier); return 0; } core_initcall(sh_pm_runtime_init); - -static int __init sh_pm_runtime_late_init(void) -{ - if (default_pm_on) - pm_genpd_poweroff_unused(); - return 0; -} -late_initcall(sh_pm_runtime_late_init);
Since genpd at late init, will try to disable unused PM domains we don't need to do it from here as well. Cc: Simon Horman <horms@verge.net.au> Cc: Magnus Damm <magnus.damm@gmail.com> Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org> --- drivers/sh/pm_runtime.c | 11 ----------- 1 file changed, 11 deletions(-)