usb: typec: tcpci_maxim: Drop GPIO includes

Message ID 20210120225045.173556-1-linus.walleij@linaro.org
State New
Headers show
Series
  • usb: typec: tcpci_maxim: Drop GPIO includes
Related show

Commit Message

Linus Walleij Jan. 20, 2021, 10:50 p.m.
This driver includes the legacy GPIO header <linux/gpio.h>,
the new GPIO header <linux/gpio/consumer.h> and
the deprecated OF GPIO header <linux/of_gpio.h> yet
fail to use symbols from any of them, so drop these
includes.

Cc: Guenter Roeck <linux@roeck-us.net>
Cc: Heikki Krogerus <heikki.krogerus@linux.intel.com>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>

---
 drivers/usb/typec/tcpm/tcpci_maxim.c | 3 ---
 1 file changed, 3 deletions(-)

-- 
2.29.2

Comments

Guenter Roeck Jan. 21, 2021, 3:59 a.m. | #1
On 1/20/21 2:50 PM, Linus Walleij wrote:
> This driver includes the legacy GPIO header <linux/gpio.h>,

> the new GPIO header <linux/gpio/consumer.h> and

> the deprecated OF GPIO header <linux/of_gpio.h> yet

> fail to use symbols from any of them, so drop these

> includes.

> 

> Cc: Guenter Roeck <linux@roeck-us.net>

> Cc: Heikki Krogerus <heikki.krogerus@linux.intel.com>

> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>


Reviewed-by: Guenter Roeck <linux@roeck-us.net>


> ---

>  drivers/usb/typec/tcpm/tcpci_maxim.c | 3 ---

>  1 file changed, 3 deletions(-)

> 

> diff --git a/drivers/usb/typec/tcpm/tcpci_maxim.c b/drivers/usb/typec/tcpm/tcpci_maxim.c

> index 319266329b42..0e2bb1235ab5 100644

> --- a/drivers/usb/typec/tcpm/tcpci_maxim.c

> +++ b/drivers/usb/typec/tcpm/tcpci_maxim.c

> @@ -5,13 +5,10 @@

>   * MAXIM TCPCI based TCPC driver

>   */

>  

> -#include <linux/gpio.h>

> -#include <linux/gpio/consumer.h>

>  #include <linux/interrupt.h>

>  #include <linux/i2c.h>

>  #include <linux/kernel.h>

>  #include <linux/module.h>

> -#include <linux/of_gpio.h>

>  #include <linux/regmap.h>

>  #include <linux/usb/pd.h>

>  #include <linux/usb/tcpm.h>

>
Heikki Krogerus Jan. 21, 2021, 7:31 a.m. | #2
On Wed, Jan 20, 2021 at 11:50:45PM +0100, Linus Walleij wrote:
> This driver includes the legacy GPIO header <linux/gpio.h>,

> the new GPIO header <linux/gpio/consumer.h> and

> the deprecated OF GPIO header <linux/of_gpio.h> yet

> fail to use symbols from any of them, so drop these

> includes.

> 

> Cc: Guenter Roeck <linux@roeck-us.net>

> Cc: Heikki Krogerus <heikki.krogerus@linux.intel.com>

> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>


Reviewed-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>


> ---

>  drivers/usb/typec/tcpm/tcpci_maxim.c | 3 ---

>  1 file changed, 3 deletions(-)

> 

> diff --git a/drivers/usb/typec/tcpm/tcpci_maxim.c b/drivers/usb/typec/tcpm/tcpci_maxim.c

> index 319266329b42..0e2bb1235ab5 100644

> --- a/drivers/usb/typec/tcpm/tcpci_maxim.c

> +++ b/drivers/usb/typec/tcpm/tcpci_maxim.c

> @@ -5,13 +5,10 @@

>   * MAXIM TCPCI based TCPC driver

>   */

>  

> -#include <linux/gpio.h>

> -#include <linux/gpio/consumer.h>

>  #include <linux/interrupt.h>

>  #include <linux/i2c.h>

>  #include <linux/kernel.h>

>  #include <linux/module.h>

> -#include <linux/of_gpio.h>

>  #include <linux/regmap.h>

>  #include <linux/usb/pd.h>

>  #include <linux/usb/tcpm.h>

> -- 

> 2.29.2


thanks,

-- 
heikki

Patch

diff --git a/drivers/usb/typec/tcpm/tcpci_maxim.c b/drivers/usb/typec/tcpm/tcpci_maxim.c
index 319266329b42..0e2bb1235ab5 100644
--- a/drivers/usb/typec/tcpm/tcpci_maxim.c
+++ b/drivers/usb/typec/tcpm/tcpci_maxim.c
@@ -5,13 +5,10 @@ 
  * MAXIM TCPCI based TCPC driver
  */
 
-#include <linux/gpio.h>
-#include <linux/gpio/consumer.h>
 #include <linux/interrupt.h>
 #include <linux/i2c.h>
 #include <linux/kernel.h>
 #include <linux/module.h>
-#include <linux/of_gpio.h>
 #include <linux/regmap.h>
 #include <linux/usb/pd.h>
 #include <linux/usb/tcpm.h>