[v2,5/5] gpio: aggregator: Remove trailing comma in terminator entries

Message ID 20210120214547.89770-5-andriy.shevchenko@linux.intel.com
State Superseded
Headers show
Series
  • [v2,1/5] lib/cmdline_kunit: add a new test case for get_options()
Related show

Commit Message

Andy Shevchenko Jan. 20, 2021, 9:45 p.m.
Remove trailing comma in terminator entries to avoid potential
expanding an array behind it.

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
 drivers/gpio/gpio-aggregator.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Linus Walleij Jan. 21, 2021, 1:17 p.m. | #1
On Wed, Jan 20, 2021 at 10:45 PM Andy Shevchenko
<andriy.shevchenko@linux.intel.com> wrote:

> Remove trailing comma in terminator entries to avoid potential
> expanding an array behind it.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>

Reviewed-by: Linus Walleij <linus.walleij@linaro.org>

Yours,
Linus Walleij
Bartosz Golaszewski Jan. 22, 2021, 10:46 a.m. | #2
On Wed, Jan 20, 2021 at 10:45 PM Andy Shevchenko
<andriy.shevchenko@linux.intel.com> wrote:
>

> Remove trailing comma in terminator entries to avoid potential

> expanding an array behind it.

>

> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>

> ---

>  drivers/gpio/gpio-aggregator.c | 4 ++--

>  1 file changed, 2 insertions(+), 2 deletions(-)

>

> diff --git a/drivers/gpio/gpio-aggregator.c b/drivers/gpio/gpio-aggregator.c

> index 40a081b095fb..0cab833fbd81 100644

> --- a/drivers/gpio/gpio-aggregator.c

> +++ b/drivers/gpio/gpio-aggregator.c

> @@ -244,7 +244,7 @@ static DRIVER_ATTR_WO(delete_device);

>  static struct attribute *gpio_aggregator_attrs[] = {

>         &driver_attr_new_device.attr,

>         &driver_attr_delete_device.attr,

> -       NULL,

> +       NULL

>  };

>  ATTRIBUTE_GROUPS(gpio_aggregator);

>

> @@ -518,7 +518,7 @@ static const struct of_device_id gpio_aggregator_dt_ids[] = {

>          * Add GPIO-operated devices controlled from userspace below,

>          * or use "driver_override" in sysfs

>          */

> -       {},

> +       {}

>  };

>  MODULE_DEVICE_TABLE(of, gpio_aggregator_dt_ids);

>  #endif

> --

> 2.29.2

>


Reviewed-by: Bartosz Golaszewski <bgolaszewski@baylibre.com>
Geert Uytterhoeven Jan. 22, 2021, 10:50 a.m. | #3
On Wed, Jan 20, 2021 at 10:45 PM Andy Shevchenko
<andriy.shevchenko@linux.intel.com> wrote:
> Remove trailing comma in terminator entries to avoid potential

> expanding an array behind it.

>

> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>


Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>


Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

Patch

diff --git a/drivers/gpio/gpio-aggregator.c b/drivers/gpio/gpio-aggregator.c
index 40a081b095fb..0cab833fbd81 100644
--- a/drivers/gpio/gpio-aggregator.c
+++ b/drivers/gpio/gpio-aggregator.c
@@ -244,7 +244,7 @@  static DRIVER_ATTR_WO(delete_device);
 static struct attribute *gpio_aggregator_attrs[] = {
 	&driver_attr_new_device.attr,
 	&driver_attr_delete_device.attr,
-	NULL,
+	NULL
 };
 ATTRIBUTE_GROUPS(gpio_aggregator);
 
@@ -518,7 +518,7 @@  static const struct of_device_id gpio_aggregator_dt_ids[] = {
 	 * Add GPIO-operated devices controlled from userspace below,
 	 * or use "driver_override" in sysfs
 	 */
-	{},
+	{}
 };
 MODULE_DEVICE_TABLE(of, gpio_aggregator_dt_ids);
 #endif