diff mbox series

HID: wacom: Assign boolean values to a bool variable

Message ID 1611128070-59752-1-git-send-email-abaci-bugfix@linux.alibaba.com
State Accepted
Commit e29c62ffb008829dc8bcc0a2ec438adc25a8255e
Headers show
Series HID: wacom: Assign boolean values to a bool variable | expand

Commit Message

Abaci Team Jan. 20, 2021, 7:34 a.m. UTC
Fix the following coccicheck warnings:

./drivers/hid/wacom_wac.c:2536:2-6: WARNING: Assignment of
0/1 to bool variable.

Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Signed-off-by: Jiapeng Zhong <abaci-bugfix@linux.alibaba.com>
---
 drivers/hid/wacom_wac.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Jiri Kosina March 8, 2021, 1:57 p.m. UTC | #1
On Wed, 20 Jan 2021, Jiapeng Zhong wrote:

> Fix the following coccicheck warnings:

> 

> ./drivers/hid/wacom_wac.c:2536:2-6: WARNING: Assignment of

> 0/1 to bool variable.

> 

> Reported-by: Abaci Robot <abaci@linux.alibaba.com>

> Signed-off-by: Jiapeng Zhong <abaci-bugfix@linux.alibaba.com>

> ---

>  drivers/hid/wacom_wac.c | 2 +-

>  1 file changed, 1 insertion(+), 1 deletion(-)

> 

> diff --git a/drivers/hid/wacom_wac.c b/drivers/hid/wacom_wac.c

> index 1bd0eb7..62b0f71 100644

> --- a/drivers/hid/wacom_wac.c

> +++ b/drivers/hid/wacom_wac.c

> @@ -2533,7 +2533,7 @@ static void wacom_wac_finger_slot(struct wacom_wac *wacom_wac,

>  	    !wacom_wac->shared->is_touch_on) {

>  		if (!wacom_wac->shared->touch_down)

>  			return;

> -		prox = 0;

> +		prox = false;

>  	}


Applied, thanks.

-- 
Jiri Kosina
SUSE Labs
diff mbox series

Patch

diff --git a/drivers/hid/wacom_wac.c b/drivers/hid/wacom_wac.c
index 1bd0eb7..62b0f71 100644
--- a/drivers/hid/wacom_wac.c
+++ b/drivers/hid/wacom_wac.c
@@ -2533,7 +2533,7 @@  static void wacom_wac_finger_slot(struct wacom_wac *wacom_wac,
 	    !wacom_wac->shared->is_touch_on) {
 		if (!wacom_wac->shared->touch_down)
 			return;
-		prox = 0;
+		prox = false;
 	}
 
 	wacom_wac->hid_data.num_received++;