amdgpu: fix clang build warning

Message ID 20210125122402.4036126-1-arnd@kernel.org
State New
Headers show
Series
  • amdgpu: fix clang build warning
Related show

Commit Message

Arnd Bergmann Jan. 25, 2021, 12:23 p.m.
From: Arnd Bergmann <arnd@arndb.de>


clang warns about the -mhard-float command line arguments
on architectures that do not support this:

clang: error: argument unused during compilation: '-mhard-float' [-Werror,-Wunused-command-line-argument]

Move this into the gcc-specific arguments.

Fixes: e77165bf7b02 ("drm/amd/display: Add DCN3 blocks to Makefile")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>

---
 drivers/gpu/drm/amd/display/dc/dcn30/Makefile  | 6 ++++--
 drivers/gpu/drm/amd/display/dc/dcn301/Makefile | 3 ++-
 drivers/gpu/drm/amd/display/dc/dcn302/Makefile | 3 ++-
 3 files changed, 8 insertions(+), 4 deletions(-)

-- 
2.29.2

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

Comments

Alex Deucher Jan. 25, 2021, 3:51 p.m. | #1
On Mon, Jan 25, 2021 at 7:24 AM Arnd Bergmann <arnd@kernel.org> wrote:
>

> From: Arnd Bergmann <arnd@arndb.de>

>

> clang warns about the -mhard-float command line arguments

> on architectures that do not support this:

>

> clang: error: argument unused during compilation: '-mhard-float' [-Werror,-Wunused-command-line-argument]

>

> Move this into the gcc-specific arguments.

>

> Fixes: e77165bf7b02 ("drm/amd/display: Add DCN3 blocks to Makefile")

> Signed-off-by: Arnd Bergmann <arnd@arndb.de>


Applied.  Thanks!

Alex

> ---

>  drivers/gpu/drm/amd/display/dc/dcn30/Makefile  | 6 ++++--

>  drivers/gpu/drm/amd/display/dc/dcn301/Makefile | 3 ++-

>  drivers/gpu/drm/amd/display/dc/dcn302/Makefile | 3 ++-

>  3 files changed, 8 insertions(+), 4 deletions(-)

>

> diff --git a/drivers/gpu/drm/amd/display/dc/dcn30/Makefile b/drivers/gpu/drm/amd/display/dc/dcn30/Makefile

> index c20331eb62e0..dfd77b3cc84d 100644

> --- a/drivers/gpu/drm/amd/display/dc/dcn30/Makefile

> +++ b/drivers/gpu/drm/amd/display/dc/dcn30/Makefile

> @@ -32,8 +32,8 @@ DCN30 = dcn30_init.o dcn30_hubbub.o dcn30_hubp.o dcn30_dpp.o dcn30_optc.o \

>

>

>  ifdef CONFIG_X86

> -CFLAGS_$(AMDDALPATH)/dc/dcn30/dcn30_resource.o := -mhard-float -msse

> -CFLAGS_$(AMDDALPATH)/dc/dcn30/dcn30_optc.o := -mhard-float -msse

> +CFLAGS_$(AMDDALPATH)/dc/dcn30/dcn30_resource.o := -msse

> +CFLAGS_$(AMDDALPATH)/dc/dcn30/dcn30_optc.o := -msse

>  endif

>

>  ifdef CONFIG_PPC64

> @@ -45,6 +45,8 @@ ifdef CONFIG_CC_IS_GCC

>  ifeq ($(call cc-ifversion, -lt, 0701, y), y)

>  IS_OLD_GCC = 1

>  endif

> +CFLAGS_$(AMDDALPATH)/dc/dcn30/dcn30_resource.o += -mhard-float

> +CFLAGS_$(AMDDALPATH)/dc/dcn30/dcn30_optc.o += -mhard-float

>  endif

>

>  ifdef CONFIG_X86

> diff --git a/drivers/gpu/drm/amd/display/dc/dcn301/Makefile b/drivers/gpu/drm/amd/display/dc/dcn301/Makefile

> index 3ca7d911d25c..09264716d1dc 100644

> --- a/drivers/gpu/drm/amd/display/dc/dcn301/Makefile

> +++ b/drivers/gpu/drm/amd/display/dc/dcn301/Makefile

> @@ -14,7 +14,7 @@ DCN301 = dcn301_init.o dcn301_resource.o dcn301_dccg.o \

>                 dcn301_dio_link_encoder.o dcn301_hwseq.o dcn301_panel_cntl.o dcn301_hubbub.o

>

>  ifdef CONFIG_X86

> -CFLAGS_$(AMDDALPATH)/dc/dcn301/dcn301_resource.o := -mhard-float -msse

> +CFLAGS_$(AMDDALPATH)/dc/dcn301/dcn301_resource.o := -msse

>  endif

>

>  ifdef CONFIG_PPC64

> @@ -25,6 +25,7 @@ ifdef CONFIG_CC_IS_GCC

>  ifeq ($(call cc-ifversion, -lt, 0701, y), y)

>  IS_OLD_GCC = 1

>  endif

> +CFLAGS_$(AMDDALPATH)/dc/dcn301/dcn301_resource.o += -mhard-float

>  endif

>

>  ifdef CONFIG_X86

> diff --git a/drivers/gpu/drm/amd/display/dc/dcn302/Makefile b/drivers/gpu/drm/amd/display/dc/dcn302/Makefile

> index 8d4924b7dc22..101620a8867a 100644

> --- a/drivers/gpu/drm/amd/display/dc/dcn302/Makefile

> +++ b/drivers/gpu/drm/amd/display/dc/dcn302/Makefile

> @@ -13,7 +13,7 @@

>  DCN3_02 = dcn302_init.o dcn302_hwseq.o dcn302_resource.o

>

>  ifdef CONFIG_X86

> -CFLAGS_$(AMDDALPATH)/dc/dcn302/dcn302_resource.o := -mhard-float -msse

> +CFLAGS_$(AMDDALPATH)/dc/dcn302/dcn302_resource.o := -msse

>  endif

>

>  ifdef CONFIG_PPC64

> @@ -24,6 +24,7 @@ ifdef CONFIG_CC_IS_GCC

>  ifeq ($(call cc-ifversion, -lt, 0701, y), y)

>  IS_OLD_GCC = 1

>  endif

> +CFLAGS_$(AMDDALPATH)/dc/dcn302/dcn302_resource.o += -mhard-float

>  endif

>

>  ifdef CONFIG_X86

> --

> 2.29.2

>

> _______________________________________________

> amd-gfx mailing list

> amd-gfx@lists.freedesktop.org

> https://lists.freedesktop.org/mailman/listinfo/amd-gfx

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

Patch

diff --git a/drivers/gpu/drm/amd/display/dc/dcn30/Makefile b/drivers/gpu/drm/amd/display/dc/dcn30/Makefile
index c20331eb62e0..dfd77b3cc84d 100644
--- a/drivers/gpu/drm/amd/display/dc/dcn30/Makefile
+++ b/drivers/gpu/drm/amd/display/dc/dcn30/Makefile
@@ -32,8 +32,8 @@  DCN30 = dcn30_init.o dcn30_hubbub.o dcn30_hubp.o dcn30_dpp.o dcn30_optc.o \
 
 
 ifdef CONFIG_X86
-CFLAGS_$(AMDDALPATH)/dc/dcn30/dcn30_resource.o := -mhard-float -msse
-CFLAGS_$(AMDDALPATH)/dc/dcn30/dcn30_optc.o := -mhard-float -msse
+CFLAGS_$(AMDDALPATH)/dc/dcn30/dcn30_resource.o := -msse
+CFLAGS_$(AMDDALPATH)/dc/dcn30/dcn30_optc.o := -msse
 endif
 
 ifdef CONFIG_PPC64
@@ -45,6 +45,8 @@  ifdef CONFIG_CC_IS_GCC
 ifeq ($(call cc-ifversion, -lt, 0701, y), y)
 IS_OLD_GCC = 1
 endif
+CFLAGS_$(AMDDALPATH)/dc/dcn30/dcn30_resource.o += -mhard-float
+CFLAGS_$(AMDDALPATH)/dc/dcn30/dcn30_optc.o += -mhard-float
 endif
 
 ifdef CONFIG_X86
diff --git a/drivers/gpu/drm/amd/display/dc/dcn301/Makefile b/drivers/gpu/drm/amd/display/dc/dcn301/Makefile
index 3ca7d911d25c..09264716d1dc 100644
--- a/drivers/gpu/drm/amd/display/dc/dcn301/Makefile
+++ b/drivers/gpu/drm/amd/display/dc/dcn301/Makefile
@@ -14,7 +14,7 @@  DCN301 = dcn301_init.o dcn301_resource.o dcn301_dccg.o \
 		dcn301_dio_link_encoder.o dcn301_hwseq.o dcn301_panel_cntl.o dcn301_hubbub.o
 
 ifdef CONFIG_X86
-CFLAGS_$(AMDDALPATH)/dc/dcn301/dcn301_resource.o := -mhard-float -msse
+CFLAGS_$(AMDDALPATH)/dc/dcn301/dcn301_resource.o := -msse
 endif
 
 ifdef CONFIG_PPC64
@@ -25,6 +25,7 @@  ifdef CONFIG_CC_IS_GCC
 ifeq ($(call cc-ifversion, -lt, 0701, y), y)
 IS_OLD_GCC = 1
 endif
+CFLAGS_$(AMDDALPATH)/dc/dcn301/dcn301_resource.o += -mhard-float
 endif
 
 ifdef CONFIG_X86
diff --git a/drivers/gpu/drm/amd/display/dc/dcn302/Makefile b/drivers/gpu/drm/amd/display/dc/dcn302/Makefile
index 8d4924b7dc22..101620a8867a 100644
--- a/drivers/gpu/drm/amd/display/dc/dcn302/Makefile
+++ b/drivers/gpu/drm/amd/display/dc/dcn302/Makefile
@@ -13,7 +13,7 @@ 
 DCN3_02 = dcn302_init.o dcn302_hwseq.o dcn302_resource.o
 
 ifdef CONFIG_X86
-CFLAGS_$(AMDDALPATH)/dc/dcn302/dcn302_resource.o := -mhard-float -msse
+CFLAGS_$(AMDDALPATH)/dc/dcn302/dcn302_resource.o := -msse
 endif
 
 ifdef CONFIG_PPC64
@@ -24,6 +24,7 @@  ifdef CONFIG_CC_IS_GCC
 ifeq ($(call cc-ifversion, -lt, 0701, y), y)
 IS_OLD_GCC = 1
 endif
+CFLAGS_$(AMDDALPATH)/dc/dcn302/dcn302_resource.o += -mhard-float
 endif
 
 ifdef CONFIG_X86